Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update clinic.rst from CPython #1167

Merged
merged 2 commits into from
Oct 1, 2023
Merged

Conversation

AA-Turner
Copy link
Member

@AA-Turner AA-Turner commented Sep 26, 2023

cc: @erlend-aasland; there were two commits that I've only just noticed weren't included in the earlier branch. Please may you rebase-merge this PR to include them?

A


📚 Documentation preview 📚: https://cpython-devguide--1167.org.readthedocs.build/

serhiy-storchaka and others added 2 commits August 19, 2023 10:13
…eyword use of parameters (python/cpython#107984)

It is now possible to deprecate passing keyword arguments for
keyword-or-positional parameters with Argument Clinic, using the new
'/ [from X.Y]' syntax.
(To be read as "positional-only from Python version X.Y")

Co-authored-by: Erlend E. Aasland <[email protected]>
Co-authored-by: Alex Waygood <[email protected]>
… that uses the limited C API (python/cpython#108584)

Co-authored-by: Alex Waygood <[email protected]>
Co-authored-by: Erlend E. Aasland <[email protected]>
@AA-Turner
Copy link
Member Author

We'll need to wait a few hours until the Python documentation is rebuilt (hence why the workflow failed when re-run).

A

@hugovk
Copy link
Member

hugovk commented Sep 29, 2023

I'd like to move the English HTML docs build from the docs server and use Read the Docs, so we get ~instant deploys instead of waiting ~24 hours. The non-HTML and translations can remain on the docs server (at least to begin with).

But that will need more planning (adding the language/version switchers, perhaps co-ordination with RtD) so something for future discussion :)

@AA-Turner
Copy link
Member Author

waiting ~24 hours

Well, of course E[wait time] is only 12 hours..!

I have hesitations about moving to RtD, but again best part of a dedicated discussion. I think we could (and should) look into rebuilding /3/ (perhaps also the pre-release versions, but certainly only the English HTML) more frequently than 24 hours, potentially every 4 or 6. I'm led to believe the expensive bits of the build are not the HTML bits. I'll open a docsbuild-scripts issue.

A

@AA-Turner
Copy link
Member Author

Opened python/docsbuild-scripts#163

@hugovk
Copy link
Member

hugovk commented Sep 29, 2023

Thanks for opening that!


Today's daily build has built today.

I've restarted the GHA job and it's passed. I don't see an option to rebuild RTD, but feel free to close/re-open if you like.

@AA-Turner
Copy link
Member Author

@erlend-aasland would you mind rebase-merging this please? I wouldn't want to progress the CPython PR without having the developer's guide being properly up-to-date.

A

@erlend-aasland erlend-aasland merged commit 0128018 into python:main Oct 1, 2023
4 of 5 checks passed
@erlend-aasland
Copy link
Contributor

@erlend-aasland would you mind rebase-merging this please? I wouldn't want to progress the CPython PR without having the developer's guide being properly up-to-date.

Thanks for taking care of this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants