use float instead of bool for should_ema and should_swap #3158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for pytorch-fbgemm-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
This pull request was exported from Phabricator. Differential Revision: D62962745 |
|
This pull request was exported from Phabricator. Differential Revision: D62962745 |
minhua-chen
force-pushed
the
export-D62962745
branch
from
d737300
to
63570bc
Compare
minhua-chen
added a commit
to minhua-chen/FBGEMM
that referenced
this pull request
Sep 20, 2024
Summary: X-link: facebookresearch/FBGEMM#253 Pull Request resolved: pytorch#3158 Use float instead of bool type for should_ema and should_swap, as bool may not be well supported in __shfl_sync() https://docs.nvidia.com/cuda/cuda-c-programming-guide/index.html#warp-shuffle-synopsis Reviewed By: q10 Differential Revision: D62962745
|
This pull request was exported from Phabricator. Differential Revision: D62962745 |
minhua-chen
added a commit
to minhua-chen/FBGEMM
that referenced
this pull request
Sep 20, 2024
Summary: X-link: facebookresearch/FBGEMM#253 Pull Request resolved: pytorch#3158 Use float instead of bool type for should_ema and should_swap, as bool may not be well supported in __shfl_sync() https://docs.nvidia.com/cuda/cuda-c-programming-guide/index.html#warp-shuffle-synopsis Reviewed By: q10, spcyppt Differential Revision: D62962745
minhua-chen
force-pushed
the
export-D62962745
branch
from
63570bc
to
747c7c1
Compare
|
This pull request was exported from Phabricator. Differential Revision: D62962745 |
minhua-chen
added a commit
to minhua-chen/FBGEMM
that referenced
this pull request
Sep 20, 2024
Summary: X-link: facebookresearch/FBGEMM#253 Pull Request resolved: pytorch#3158 Use float instead of bool type for should_ema and should_swap, as bool may not be well supported in __shfl_sync() https://docs.nvidia.com/cuda/cuda-c-programming-guide/index.html#warp-shuffle-synopsis Reviewed By: q10, spcyppt Differential Revision: D62962745
minhua-chen
force-pushed
the
export-D62962745
branch
from
747c7c1
to
4863eb8
Compare
|
This pull request was exported from Phabricator. Differential Revision: D62962745 |
minhua-chen
force-pushed
the
export-D62962745
branch
from
4863eb8
to
14a1c77
Compare
|
This pull request was exported from Phabricator. Differential Revision: D62962745 |
minhua-chen
added a commit
to minhua-chen/FBGEMM
that referenced
this pull request
Sep 21, 2024
Summary: X-link: facebookresearch/FBGEMM#253 Pull Request resolved: pytorch#3158 Use float instead of bool type for should_ema and should_swap, as bool may not be well supported in __shfl_sync() https://docs.nvidia.com/cuda/cuda-c-programming-guide/index.html#warp-shuffle-synopsis Reviewed By: q10, spcyppt Differential Revision: D62962745
minhua-chen
force-pushed
the
export-D62962745
branch
from
14a1c77
to
9721228
Compare
|
This pull request was exported from Phabricator. Differential Revision: D62962745 |
minhua-chen
added a commit
to minhua-chen/FBGEMM
that referenced
this pull request
Sep 21, 2024
Summary: X-link: facebookresearch/FBGEMM#253 Pull Request resolved: pytorch#3158 Use float instead of bool type for should_ema and should_swap, as bool may not be well supported in __shfl_sync() https://docs.nvidia.com/cuda/cuda-c-programming-guide/index.html#warp-shuffle-synopsis Reviewed By: q10, spcyppt Differential Revision: D62962745
minhua-chen
force-pushed
the
export-D62962745
branch
from
9721228
to
bd4da4b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D62962745 |
minhua-chen
added a commit
to minhua-chen/FBGEMM
that referenced
this pull request
Sep 21, 2024
Summary: X-link: facebookresearch/FBGEMM#253 Pull Request resolved: pytorch#3158 Use float instead of bool type for should_ema and should_swap, as bool may not be well supported in __shfl_sync() https://docs.nvidia.com/cuda/cuda-c-programming-guide/index.html#warp-shuffle-synopsis Reviewed By: q10, spcyppt Differential Revision: D62962745
minhua-chen
force-pushed
the
export-D62962745
branch
from
bd4da4b
to
86cf79f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D62962745 |
minhua-chen
added a commit
to minhua-chen/FBGEMM
that referenced
this pull request
Sep 21, 2024
Summary: X-link: facebookresearch/FBGEMM#253 Pull Request resolved: pytorch#3158 Use float instead of bool type for should_ema and should_swap, as bool may not be well supported in __shfl_sync() https://docs.nvidia.com/cuda/cuda-c-programming-guide/index.html#warp-shuffle-synopsis Reviewed By: q10, spcyppt Differential Revision: D62962745
minhua-chen
force-pushed
the
export-D62962745
branch
from
86cf79f
to
889d655
Compare
|
This pull request was exported from Phabricator. Differential Revision: D62962745 |
minhua-chen
added a commit
to minhua-chen/FBGEMM
that referenced
this pull request
Sep 21, 2024
Summary: X-link: facebookresearch/FBGEMM#253 Pull Request resolved: pytorch#3158 Use float instead of bool type for should_ema and should_swap, as bool may not be well supported in __shfl_sync() https://docs.nvidia.com/cuda/cuda-c-programming-guide/index.html#warp-shuffle-synopsis Reviewed By: q10, spcyppt Differential Revision: D62962745
minhua-chen
force-pushed
the
export-D62962745
branch
from
889d655
to
98b81b4
Compare
minhua-chen
added a commit
to minhua-chen/FBGEMM
that referenced
this pull request
Sep 21, 2024
Summary: X-link: facebookresearch/FBGEMM#253 Pull Request resolved: pytorch#3158 Use float instead of bool type for should_ema and should_swap, as bool may not be well supported in __shfl_sync() https://docs.nvidia.com/cuda/cuda-c-programming-guide/index.html#warp-shuffle-synopsis Reviewed By: q10, spcyppt Differential Revision: D62962745
minhua-chen
force-pushed
the
export-D62962745
branch
from
ebf7582
to
323c6e0
Compare
|
This pull request was exported from Phabricator. Differential Revision: D62962745 |
minhua-chen
added a commit
to minhua-chen/FBGEMM
that referenced
this pull request
Sep 21, 2024
Summary: X-link: facebookresearch/FBGEMM#253 Pull Request resolved: pytorch#3158 Use float instead of bool type for should_ema and should_swap, as bool may not be well supported in __shfl_sync() https://docs.nvidia.com/cuda/cuda-c-programming-guide/index.html#warp-shuffle-synopsis Reviewed By: q10, spcyppt Differential Revision: D62962745
minhua-chen
force-pushed
the
export-D62962745
branch
from
323c6e0
to
fdb8cba
Compare
|
This pull request was exported from Phabricator. Differential Revision: D62962745 |
minhua-chen
added a commit
to minhua-chen/FBGEMM
that referenced
this pull request
Sep 21, 2024
Summary: X-link: facebookresearch/FBGEMM#253 Pull Request resolved: pytorch#3158 Use float instead of bool type for should_ema and should_swap, as bool may not be well supported in __shfl_sync() https://docs.nvidia.com/cuda/cuda-c-programming-guide/index.html#warp-shuffle-synopsis Reviewed By: q10, spcyppt Differential Revision: D62962745
minhua-chen
force-pushed
the
export-D62962745
branch
from
fdb8cba
to
37db4fe
Compare
|
This pull request was exported from Phabricator. Differential Revision: D62962745 |
minhua-chen
added a commit
to minhua-chen/FBGEMM
that referenced
this pull request
Sep 21, 2024
Summary: X-link: facebookresearch/FBGEMM#253 Pull Request resolved: pytorch#3158 Use float instead of bool type for should_ema and should_swap, as bool may not be well supported in __shfl_sync() https://docs.nvidia.com/cuda/cuda-c-programming-guide/index.html#warp-shuffle-synopsis Reviewed By: q10, spcyppt Differential Revision: D62962745
minhua-chen
force-pushed
the
export-D62962745
branch
from
37db4fe
to
386a5d6
Compare
|
This pull request was exported from Phabricator. Differential Revision: D62962745 |
minhua-chen
added a commit
to minhua-chen/FBGEMM
that referenced
this pull request
Sep 21, 2024
Summary: X-link: facebookresearch/FBGEMM#253 Pull Request resolved: pytorch#3158 Use float instead of bool type for should_ema and should_swap, as bool may not be well supported in __shfl_sync() https://docs.nvidia.com/cuda/cuda-c-programming-guide/index.html#warp-shuffle-synopsis Reviewed By: q10, spcyppt Differential Revision: D62962745
minhua-chen
force-pushed
the
export-D62962745
branch
from
386a5d6
to
444d784
Compare
|
This pull request was exported from Phabricator. Differential Revision: D62962745 |
minhua-chen
added a commit
to minhua-chen/FBGEMM
that referenced
this pull request
Sep 21, 2024
Summary: X-link: facebookresearch/FBGEMM#253 Pull Request resolved: pytorch#3158 Use float instead of bool type for should_ema and should_swap, as bool may not be well supported in __shfl_sync() https://docs.nvidia.com/cuda/cuda-c-programming-guide/index.html#warp-shuffle-synopsis Reviewed By: q10, spcyppt Differential Revision: D62962745
minhua-chen
force-pushed
the
export-D62962745
branch
from
444d784
to
1e0b6bd
Compare
|
This pull request was exported from Phabricator. Differential Revision: D62962745 |
minhua-chen
added a commit
to minhua-chen/FBGEMM
that referenced
this pull request
Sep 21, 2024
Summary: X-link: facebookresearch/FBGEMM#253 Pull Request resolved: pytorch#3158 Use float instead of bool type for should_ema and should_swap, as bool may not be well supported in __shfl_sync() https://docs.nvidia.com/cuda/cuda-c-programming-guide/index.html#warp-shuffle-synopsis Reviewed By: q10, spcyppt Differential Revision: D62962745
minhua-chen
force-pushed
the
export-D62962745
branch
from
1e0b6bd
to
4db9366
Compare
|
This pull request was exported from Phabricator. Differential Revision: D62962745 |
minhua-chen
added a commit
to minhua-chen/FBGEMM
that referenced
this pull request
Sep 21, 2024
Summary: X-link: facebookresearch/FBGEMM#253 Pull Request resolved: pytorch#3158 Use float instead of bool type for should_ema and should_swap, as bool may not be well supported in __shfl_sync() https://docs.nvidia.com/cuda/cuda-c-programming-guide/index.html#warp-shuffle-synopsis Reviewed By: q10, spcyppt Differential Revision: D62962745
minhua-chen
force-pushed
the
export-D62962745
branch
from
4db9366
to
fc7f817
Compare
Summary: X-link: facebookresearch/FBGEMM#253 Pull Request resolved: pytorch#3158 Use float instead of bool type for should_ema and should_swap, as bool may not be well supported in __shfl_sync() https://docs.nvidia.com/cuda/cuda-c-programming-guide/index.html#warp-shuffle-synopsis Reviewed By: q10, spcyppt Differential Revision: D62962745
|
This pull request was exported from Phabricator. Differential Revision: D62962745 |
minhua-chen
force-pushed
the
export-D62962745
branch
from
fc7f817
to
0311ee0
Compare
|
This pull request has been merged in 2889f3a. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Use float instead of bool type for should_ema and should_swap, as bool may not be well supported in __shfl_sync()
https://docs.nvidia.com/cuda/cuda-c-programming-guide/index.html#warp-shuffle-synopsis
Differential Revision: D62962745