Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use float instead of bool for should_ema and should_swap #3158

Closed
wants to merge 1 commit into from
Closed

use float instead of bool for should_ema and should_swap #3158

wants to merge 1 commit into from

Commits on Sep 21, 2024

  1. use float instead of bool for should_ema and should_swap (pytorch#3158) 

    Summary:
X-link: facebookresearch/FBGEMM#253

Pull Request resolved: pytorch#3158

 Use float instead of bool type for should_ema and should_swap, as bool may not be well supported in __shfl_sync()
https://docs.nvidia.com/cuda/cuda-c-programming-guide/index.html#warp-shuffle-synopsis

Reviewed By: q10, spcyppt

Differential Revision: D62962745
    @minhua-chen @facebook-github-bot
    minhua-chen authored and facebook-github-bot committed Sep 21, 2024
    Configuration menu
    Copy the full SHA
    0311ee0 View commit details
    Browse the repository at this point in the history