Introduce parameter for config to materialize_appdef #848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D54777218 |
yikaiMeta
approved these changes
Mar 14, 2024
|
This pull request was exported from Phabricator. Differential Revision: D54777218 |
Summary: Move away from using `component_defaults` to pass config values to `materialize_appdef`. Instead, create a new parameter for the config. This is so the api can also use configs, not just cli - assume yaml config is a dict representation (1:1 mapping) of component arg names to component arg values - can take primitives or nested dicts for the arg type - send this dict to `materialize_appdef` as an optional param, merge it with the namespace created by the argparser - ensure required/ args with defaults still work Reviewed By: yikaiMeta, Sanjay-Ganeshan Differential Revision: D54777218
ishachirimar
force-pushed
the
export-D54777218
branch
from
f539985
to
47681e8
Compare
|
This pull request was exported from Phabricator. Differential Revision: D54777218 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add optional param for config file to
materialize_appdef.If there is a config file, then it will be merged with the defaults/command line component arg values.
Differential Revision: D54777218