Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce parameter for config to materialize_appdef #848

Merged
merged 1 commit into from
Mar 18, 2024

Commits on Mar 18, 2024

  1. Introduce parameter for config to materialize_appdef (pytorch#848)

    Summary:
    
    Move away from using `component_defaults` to pass config values to `materialize_appdef`. Instead, create a new parameter for the config. This is so the api can also use configs, not just cli 
    
    - assume yaml config is a dict representation (1:1 mapping) of component arg names to component arg values
    - can take primitives or nested dicts for the arg type
    - send this dict to `materialize_appdef` as an optional param, merge it with the namespace created by the argparser
    - ensure required/ args with defaults still work
    
    Reviewed By: yikaiMeta, Sanjay-Ganeshan
    
    Differential Revision: D54777218
    ishachirimar authored and facebook-github-bot committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    47681e8 View commit details
    Browse the repository at this point in the history