Adapt reader mviri_l1b_fiduceo_nc #2802
+187
−29
Open
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main)
failed
Jun 6, 2024 in 32s
CodeScene PR Check
❌ Code Health Quality Gates: FAILED
- Declining Code Health: 2 findings(s) 🚩
Details
🚩 Declining Code Health (highest to lowest):
- Code Duplication test_mviri_l1b_fiduceo_nc.py
- Large Method test_mviri_l1b_fiduceo_nc.py: fixture_fake_dataset
Annotations
Check warning on line 649 in satpy/tests/reader_tests/test_mviri_l1b_fiduceo_nc.py
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ New issue: Code Duplication
The module contains 2 functions with similar structure: TestInterpolator.fixture_acq_time_vis_exp,TestInterpolator.fixture_time_ir_wv. Avoid duplicated, aka copy-pasted, code inside the module. More duplication lowers the code health.
Check warning on line 332 in satpy/tests/reader_tests/test_mviri_l1b_fiduceo_nc.py
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ New issue: Large Method
fixture_fake_dataset has 73 lines, threshold = 70. Large functions with many lines of code are generally harder to understand and lower the code health. Avoid adding more lines to this function.
Loading