Bugfix for Sentinel-2 radiance calculation #2896
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ance calculation.
simonrp84
force-pushed
the
Sen2_Radiance
branch
from
49e1780
to
c1348f6
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2896 +/- ##
=======================================
Coverage 96.05% 96.05%
=======================================
Files 370 370
Lines 54320 54356 +36
=======================================
+ Hits 52177 52212 +35
- Misses 2143 2144 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Pull Request Test Coverage Report for Build 10740356237Details
💛 - Coveralls |
mraspaud
reviewed
Sep 20, 2024
Comment on lines
+112
to
+114
| #else: | ||
| # For L1B the radiances can be directly computed from the digital counts. | ||
| #return self._mda.calibrate_to_radiances_l1b(proj, self._channel) |
There was a problem hiding this comment.
I'd like to leave that there as a placeholder. Soon the L1b data will be made available to users, and this section of code will then become useful :-)
| if irrads is not None: | ||
| solar_irrad = {int(irr.attrib["bandId"]): float(irr.text) for irr in irrads} | ||
| else: | ||
| solar_irrad = {} |
| sed = self.root.find(".//U") | ||
| if sed is not None: | ||
| return float(sed.text) | ||
| return -1 |
There was a problem hiding this comment.
I'm not really found of this. Would it be possible to raise an error here and catch it downstream?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the radiance calculation for Sentinel-2 data. Currently, the code uses the method suitable for L1b counts -> radiance computation. However, L1b data is not (yet) available to users and the procedure is different for L1c data that's available via the Copernicus data ecosystem.
This PR switches to use the correct calculation.
In addition, I made some changes to the reader code in preparation for the upcoming availability of L1B data for Sentinel-2. This data isn't yet supported by the reader, though, so I have added an explicit error message / reader failure mode if the user tries to process L1B data.