Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix for Sentinel-2 radiance calculation #2896

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Add docs note to S2/MSI specifying that L1B data is not currently sup…

38a05d1
Select commit
Loading
Failed to load commit list.
Open

Bugfix for Sentinel-2 radiance calculation #2896

Add docs note to S2/MSI specifying that L1B data is not currently sup…
38a05d1
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) succeeded Sep 6, 2024 in 41s

CodeScene PR Check

✅ Code Health Quality Gates: OK

Change in average Code Health of affected files: -0.27 (9.95 -> 9.69)

  • Declining Code Health: 1 findings(s) 🚩

View detailed results in CodeScene

Details

🚩 Declining Code Health (highest to lowest):

  • Excess Number of Function Arguments test_msi_safe.py: TestSAFEMSIL1C.test_calibration_and_masking

Annotations

Check warning on line 1668 in satpy/tests/reader_tests/test_msi_safe.py

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Excess Number of Function Arguments 

TestSAFEMSIL1C.test_calibration_and_masking has 5 arguments, threshold = 4. This function has too many arguments, indicating a lack of encapsulation. Avoid adding more arguments.
View more details on CodeScene Delta Analysis