-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release 1.0.0 #3
base: main
Are you sure you want to change the base?
Conversation
…ceptor per provider)
…he same for shedlock and also validate it
@gastaldi Could you please change the default branch to master ? many thanks |
shouldn't the default branch be |
@dcdh done, |
I also renamed to |
.github/project.yml
Outdated
@@ -1,4 +1,4 @@ | |||
release: | |||
current-version: "0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd recommend to have a separate PR to trigger the release workflow (which is triggered when this file is changed)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello George, it was my intention to trigger a release. I'll revert it.
Should I rename the branch ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dcdh no need to, it can be named as you like
…er should be able to change the value at runtime
@gastaldi build is ok. May I merge it ? and next release it ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good
# Conflicts: # deployment/src/test/java/io/quarkiverse/shedlock/test/ShedlockDevModeTest.java # deployment/src/test/java/io/quarkiverse/shedlock/test/ShedlockTest.java # pom.xml
Hello @gastaldi I've added some commits. I would like to do a release as soon as possible. I mainly rewrite all the tests because they where badly done regarding the fact that I've got injected datasource and other inside integration tests in tests code. Which is not convenient and must be avoided. I've done it because I was not aware on how to do regarding integration testing. Regarding the doc I've faces some issue because the way asciidoc is working has been changed following the latest release of Quarkus. |
Do not build yet. Just for review.
Build should be fixed when this issue quarkusio/quarkus#39181 will be released.