Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release 1.0.0 #3

Open
wants to merge 28 commits into
base: main
Choose a base branch
from
Open

release 1.0.0 #3

wants to merge 28 commits into from

Conversation

dcdh
Copy link
Member

@dcdh dcdh commented Mar 5, 2024

Do not build yet. Just for review.

Build should be fixed when this issue quarkusio/quarkus#39181 will be released.

@dcdh dcdh requested a review from a team as a code owner March 5, 2024 21:18
@dcdh
Copy link
Member Author

dcdh commented Mar 5, 2024

@gastaldi Could you please change the default branch to master ? many thanks

@melloware
Copy link

shouldn't the default branch be main?

@gastaldi
Copy link
Member

gastaldi commented Mar 5, 2024

@dcdh done, main is now the default branch

@gastaldi
Copy link
Member

gastaldi commented Mar 5, 2024

@gastaldi Could you please change the default branch to master ? many thanks

I also renamed to main to follow the same pattern from the other repositories, hope that's okay

@@ -1,4 +1,4 @@
release:
current-version: "0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd recommend to have a separate PR to trigger the release workflow (which is triggered when this file is changed)

Copy link
Member Author

@dcdh dcdh Mar 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello George, it was my intention to trigger a release. I'll revert it.

Should I rename the branch ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dcdh no need to, it can be named as you like

@dcdh
Copy link
Member Author

dcdh commented Mar 12, 2024

@gastaldi build is ok. May I merge it ? and next release it ?

Copy link
Member

@gastaldi gastaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good

dcdh added 4 commits December 24, 2024 11:25
# Conflicts:
#	deployment/src/test/java/io/quarkiverse/shedlock/test/ShedlockDevModeTest.java
#	deployment/src/test/java/io/quarkiverse/shedlock/test/ShedlockTest.java
#	pom.xml
@dcdh
Copy link
Member Author

dcdh commented Dec 24, 2024

Hello @gastaldi I've added some commits. I would like to do a release as soon as possible.

I mainly rewrite all the tests because they where badly done regarding the fact that I've got injected datasource and other inside integration tests in tests code. Which is not convenient and must be avoided. I've done it because I was not aware on how to do regarding integration testing.
Moreover, it was lacking on tests regarding the effective lock mechanism behaviors. I added some tests to validate the locking behaviors.

Regarding the doc I've faces some issue because the way asciidoc is working has been changed following the latest release of Quarkus.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants