Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Picocli warnings and startup and native execution #1341

Conversation

michalvavrik
Copy link
Member

@michalvavrik michalvavrik commented Sep 26, 2024

Summary

So far when we run Picocli apps we have experienced:

  • we need to call BaseService::start async because the app never gets ready
  • there are strange warnings WARNING Exception reading file log file because log file doesn't exist
  • native execution fails in some cases (like in the QE TS, see daily builds)

This PR fixes that. I have tested it with changes that I pushed into this PR quarkus-qe/quarkus-test-suite#2043.

Please check the relevant options

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Dependency update
  • Refactoring
  • Release (follows conventions described in the RELEASE.md)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Example scenarios has been updated / added
  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@michalvavrik michalvavrik force-pushed the feature/fix-picocli-warns-and-native branch 2 times, most recently from de76851 to 971da41 Compare September 26, 2024 16:14
@michalvavrik michalvavrik force-pushed the feature/fix-picocli-warns-and-native branch 3 times, most recently from e4831ff to 286843c Compare September 26, 2024 17:51
@michalvavrik michalvavrik force-pushed the feature/fix-picocli-warns-and-native branch from 286843c to ff5bfde Compare September 26, 2024 17:56
Copy link
Contributor

@jcarranzan jcarranzan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me for our CLI testing apps.

@michalvavrik michalvavrik merged commit 246f369 into quarkus-qe:main Sep 27, 2024
8 checks passed
@michalvavrik michalvavrik deleted the feature/fix-picocli-warns-and-native branch September 27, 2024 07:30
@michalvavrik michalvavrik added the triage/backport-1.5? Quarkus 3.15 stream label Oct 2, 2024
jcarranzan added a commit to jcarranzan/quarkus-test-framework that referenced this pull request Oct 2, 2024
@michalvavrik michalvavrik removed the triage/backport-1.5? Quarkus 3.15 stream label Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants