Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix quarkus-picocli tests with native mode #2043

Merged
merged 2 commits into from
Sep 27, 2024

Conversation

jcarranzan
Copy link
Contributor

Summary

Fix the error in native here https://github.com/quarkus-qe/quarkus-test-suite/actions/runs/11005556450

Please select the relevant options.

  • Bug fix (non-breaking change which fixes an issue)
  • Dependency update
  • Refactoring
  • Backport
  • New scenario (non-breaking change which adds functionality)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@jcarranzan
Copy link
Contributor Author

There is a Logs handling problem in native and also in ARM, so I'll fix it.

@michalvavrik
Copy link
Member

michalvavrik commented Sep 26, 2024

There is a Logs handling problem in native and also in ARM, so I'll fix it.

log handling is not cause of the failure, I fixed the native failure, please open Quarkus Test Framework issue for the WARNING Exception reading file log file because I don't have space to deal with it now. Thanks

@jcarranzan
Copy link
Contributor Author

Thanks for your fix @michalvavrik , I'll rebase the commits.

@michalvavrik
Copy link
Member

Thanks for your fix @michalvavrik , I'll rebase the commits.

thanks to changes enforced by Fedor and MichalJ they are rebased when you click to the merge button, but I don't mind, whatever suits you

@jcarranzan
Copy link
Contributor Author

thanks to changes enforced by Fedor and MichalJ they are rebased when you click to the merge button, but I don't mind, whatever suits you

Oh I didn't know it, I never use the UI buttons in GH, I usually do it through the command line in my IntelliJ

michalvavrik
michalvavrik previously approved these changes Sep 26, 2024
@michalvavrik
Copy link
Member

So, no idea why it works locally but never works in the CI, but I've created proper fix for the application start and for logging (so that we fixed logging and there will be no warnings). I'll push version that will only succeed with quarkus-qe/quarkus-test-framework#1341 so let's wait for the rebase. I am pushing it so that you can test it with the FW PR.

@michalvavrik michalvavrik dismissed their stale review September 26, 2024 16:18

many changes, will have a look when this is rebased on the fix

@michalvavrik
Copy link
Member

Native issue is different to what I was debugging (before it was about these warnings that are gone). I'll check what it is about.

@michalvavrik
Copy link
Member

Strange part is that I cannot reproduce it doing exactly same as the CI does so far.

@michalvavrik
Copy link
Member

Ha, I figured it out, you didn't specify relative path to the parent. Native build seems to be fixed now.

@michalvavrik michalvavrik removed their request for review September 27, 2024 15:43
@fedinskiy fedinskiy merged commit 8ef4db7 into quarkus-qe:main Sep 27, 2024
8 checks passed
@michalvavrik michalvavrik deleted the enable-native-picocli branch September 27, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants