-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix quarkus-picocli tests with native mode #2043
Conversation
2bf0026
to
c47607c
Compare
There is a Logs handling problem in native and also in ARM, so I'll fix it. |
log handling is not cause of the failure, I fixed the native failure, please open Quarkus Test Framework issue for the |
Thanks for your fix @michalvavrik , I'll rebase the commits. |
thanks to changes enforced by Fedor and MichalJ they are rebased when you click to the merge button, but I don't mind, whatever suits you |
d55e9b4
to
17f94c7
Compare
Oh I didn't know it, I never use the UI buttons in GH, I usually do it through the command line in my IntelliJ |
So, no idea why it works locally but never works in the CI, but I've created proper fix for the application start and for logging (so that we fixed logging and there will be no warnings). I'll push version that will only succeed with quarkus-qe/quarkus-test-framework#1341 so let's wait for the rebase. I am pushing it so that you can test it with the FW PR. |
6018878
to
b13a893
Compare
many changes, will have a look when this is rebased on the fix
b13a893
to
df0979e
Compare
df0979e
to
b9a6c39
Compare
b9a6c39
to
b6c6282
Compare
Native issue is different to what I was debugging (before it was about these warnings that are gone). I'll check what it is about. |
Strange part is that I cannot reproduce it doing exactly same as the CI does so far. |
Ha, I figured it out, you didn't specify relative path to the parent. Native build seems to be fixed now. |
Summary
Fix the error in native here https://github.com/quarkus-qe/quarkus-test-suite/actions/runs/11005556450
Please select the relevant options.
run tests
phrase in comment)Checklist: