Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add coverage for quarkus-picocli #2003

Merged
merged 1 commit into from
Sep 20, 2024
Merged

Add coverage for quarkus-picocli #2003

merged 1 commit into from
Sep 20, 2024

Conversation

jcarranzan
Copy link
Contributor

@jcarranzan jcarranzan commented Sep 12, 2024 •
edited
Loading

Summary

JIRA: https://issues.redhat.com/browse/QUARKUS-4221
Currently, we are going to support Quarkus Picocli, so that's the reason for this new test coverage.

Please select the relevant options.

  • Bug fix (non-breaking change which fixes an issue)
  • Dependency update
  • Refactoring
  • Backport
  • New scenario (non-breaking change which adds functionality)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@rsvoboda
Copy link
Member

@fedinskiy please take a look

@jcarranzan
Copy link
Contributor Author

@rsvoboda It's just an initial draft I will need (lot of) changes yet before @fedinskiy starting review it...

@jcarranzan jcarranzan force-pushed the feature/picocli-coverage branch 3 times, most recently from 0c6beac to ed8a63d Compare September 16, 2024 10:38
@github-actions github-actions bot added the triage/flaky-test Signal that flaky tests were detected during CI run label Sep 16, 2024
@github-actions GitHub Actions
Copy link

Following jobs contain at least one flaky test: 'PR - Linux - JVM build - Latest Version'

@jcarranzan jcarranzan force-pushed the feature/picocli-coverage branch 4 times, most recently from 402254e to 443e67a Compare September 17, 2024 11:50
@jcarranzan jcarranzan mentioned this pull request Sep 17, 2024
Merged
1 task
@jcarranzan jcarranzan marked this pull request as ready for review September 18, 2024 14:41
fedinskiy
fedinskiy requested changes Sep 19, 2024
View reviewed changes
quarkus-picocli/src/main/java/io/quarkus/ts/qe/configuration/Config.java Show resolved Hide resolved
quarkus-picocli/src/test/java/PicocliIT.java Outdated Show resolved Hide resolved
quarkus-picocli/src/test/java/PicocliIT.java Outdated Show resolved Hide resolved
quarkus-picocli/src/test/java/ProdiIT.java Outdated Show resolved Hide resolved
quarkus-picocli/src/test/java/PicocliIT.java Outdated Show resolved Hide resolved
quarkus-picocli/src/test/java/OpenShiftPicocliIT.java Outdated Show resolved Hide resolved
@jcarranzan jcarranzan force-pushed the feature/picocli-coverage branch 2 times, most recently from 1738fc9 to 8130b0a Compare September 20, 2024 08:44
michalvavrik
michalvavrik previously requested changes Sep 20, 2024
View reviewed changes
Copy link
Member

@michalvavrik michalvavrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is absolutely no test class, but you only add new classes, new module. How this PR tests anything?

@jcarranzan
Copy link
Contributor Author

There is absolutely no test class, but you only add new classes, new module. How this PR tests anything?

My src/folder wasn't upload, sorry about that, it's done now :)

@fedinskiy
Copy link
Contributor

fedinskiy commented Sep 20, 2024 •
edited
Loading

@jcarranzan as Michal've already noticed, it looks like you've deleted all tests in the last update. Please recheck

UPD: I see it was already updated

fedinskiy
fedinskiy requested changes Sep 20, 2024
View reviewed changes
quarkus-picocli/src/test/java/PicocliProdIT.java Outdated Show resolved Hide resolved
quarkus-picocli/src/test/java/PicocliProdIT.java Outdated Show resolved Hide resolved
quarkus-picocli/src/test/java/PicocliDevIT.java Outdated Show resolved Hide resolved
@jcarranzan jcarranzan force-pushed the feature/picocli-coverage branch 2 times, most recently from 24a83a4 to 5dc12f5 Compare September 20, 2024 12:23
@fedinskiy
Copy link
Contributor

Thank you! Can be merged if CI is green

@github-actions GitHub Actions
Copy link

Following jobs contain at least one flaky test: 'PR - Linux - JVM build - Latest Version'

@michalvavrik
Copy link
Member

michalvavrik commented Sep 20, 2024 •
edited
Loading

Thank you! Can be merged if CI is green

Sadly I went through last GH CI run (before PR updated 'name' in pom) and it seems that this CI doesn't test this PR. I think there is some workflow bug, but won't look into now. I'll merge this when validation succeeds and we can see whether daily build pass or not.

@michalvavrik michalvavrik merged commit ee2795a into quarkus-qe:main Sep 20, 2024
6 of 7 checks passed
@michalvavrik michalvavrik deleted the feature/picocli-coverage branch September 20, 2024 18:29
@fedinskiy fedinskiy mentioned this pull request Sep 25, 2024
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalvavrik michalvavrik michalvavrik left review comments

@fedinskiy fedinskiy fedinskiy approved these changes

Assignees
No one assigned
Labels
triage/flaky-test Signal that flaky tests were detected during CI run
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jcarranzan @rsvoboda @fedinskiy @michalvavrik