Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix DevModeMultipleReactiveSqlClientsIT on Aarch64 by switching MSSQL for MariaDB #2041

Merged
merged 1 commit into from
Sep 24, 2024
Merged

Fix DevModeMultipleReactiveSqlClientsIT on Aarch64 by switching MSSQL for MariaDB #2041

merged 1 commit into from
Sep 24, 2024

Conversation

michalvavrik
Copy link
Member

@michalvavrik michalvavrik commented Sep 24, 2024 •
edited
Loading

Summary

This test has 3 dbs (pg, mysql, mssql), MsSQL doesn't work on ARM64, other 2 options (DB2, Oracle) doesn't have OOTB containers for this platform. QUARKUS-1080 and QUARKUS-1408 doesn't seem specific for MSSQL. Hence using MariaDB.

Please select the relevant options.

  • Bug fix (non-breaking change which fixes an issue)
  • Dependency update
  • Refactoring
  • Backport
  • New scenario (non-breaking change which adds functionality)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@rsvoboda rsvoboda requested a review from mjurc September 24, 2024 11:55
@michalvavrik michalvavrik force-pushed the feature/fix-multi-db-dev-svc-on-arm64 branch from adbf3f6 to da2ebba Compare September 24, 2024 11:56
mjurc
mjurc approved these changes Sep 24, 2024
View reviewed changes
Copy link
Member

@mjurc mjurc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix, lgtm.

@mjurc mjurc merged commit 2935041 into quarkus-qe:main Sep 24, 2024
8 checks passed
@michalvavrik michalvavrik deleted the feature/fix-multi-db-dev-svc-on-arm64 branch September 24, 2024 15:27
fedinskiy pushed a commit to fedinskiy/quarkus-test-suite that referenced this pull request Sep 25, 2024
@michalvavrik @fedinskiy
Fix DevModeMultipleReactiveSqlClientsIT on Aarch64 (quarkus-qe#2041)
16fe4a2
@fedinskiy fedinskiy mentioned this pull request Sep 25, 2024
Merged
9 tasks
fedinskiy pushed a commit to fedinskiy/quarkus-test-suite that referenced this pull request Sep 25, 2024
@michalvavrik @fedinskiy
Fix DevModeMultipleReactiveSqlClientsIT on Aarch64 (quarkus-qe#2041)
278d022 
(cherry picked from commit 2935041)
michalvavrik added a commit that referenced this pull request Sep 25, 2024
@michalvavrik
Fix DevModeMultipleReactiveSqlClientsIT on Aarch64 (#2041)
2b038c5 
(cherry picked from commit 2935041)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjurc mjurc mjurc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rewrite DevModeReactiveSqlClientsIT to use two DBs that run on all platforms
3 participants
@michalvavrik @mjurc @fedinskiy