Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix QuarkusCliTlsCommandIT truststore config property value on Windows #2042

Merged

Conversation

michalvavrik
Copy link
Member

@michalvavrik michalvavrik commented Sep 24, 2024

Summary

Here #2036 I fixed the issue for a keystore and didn't realize there is another issue with a truststore. I apologize for doing it on parts, but honestly, spawning Windows machine and setting up environment (or adjusting job) is way more time consuming then just fixing it here. Hope it's alright. Fixes:

[ERROR] io.quarkus.ts.quarkus.cli.tls.surefire.TlsCommandTest.testCommunicationUsingGeneratedCerts -- Time elapsed: 1.479 s <<< ERROR!
java.io.FileNotFoundException: C:UsersnameAppDataLocalTempquarkus-tls-command-tests17294939791165376470 ls-command-testquarkus-qe-cert-truststore.p12 (The filename, directory name, or volume label syntax is incorrect)

If there will be yet another issue after this one, I'll setup an instance.

Please select the relevant options.

  • Bug fix (non-breaking change which fixes an issue)
  • Dependency update
  • Refactoring
  • Backport
  • New scenario (non-breaking change which adds functionality)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@jcarranzan jcarranzan merged commit 82c02d3 into quarkus-qe:main Sep 24, 2024
8 checks passed
@michalvavrik michalvavrik deleted the feature/tls-win-fix-for-truststore branch September 24, 2024 13:58
fedinskiy pushed a commit to fedinskiy/quarkus-test-suite that referenced this pull request Sep 25, 2024
@fedinskiy fedinskiy mentioned this pull request Sep 25, 2024
9 tasks
fedinskiy pushed a commit to fedinskiy/quarkus-test-suite that referenced this pull request Sep 25, 2024
michalvavrik added a commit that referenced this pull request Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants