Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make control message smaller, so to not break ARM tests #2044

Merged
merged 1 commit into from
Sep 24, 2024
Merged

Make control message smaller, so to not break ARM tests #2044

merged 1 commit into from
Sep 24, 2024

Conversation

fedinskiy
Copy link
Contributor

Summary

While testing on ARM, our control message (64 symbols) is not shown in logs. I presume, that on ARM this message weight more, than 128 bytes; and so it is filtered by Quarkus. We should be careful around encodings and byte limits in the future.

Please select the relevant options.

  • Bug fix (non-breaking change which fixes an issue)
  • Dependency update
  • Refactoring
  • Backport
  • New scenario (non-breaking change which adds functionality)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@fedinskiy
Make control message smaller, so to not break ARM tests
fed2b5d 
While testing on ARM, our control message (64 symbols) is not shown in
logs. I presume, that on ARM this message weight more, than 128 bytes;
and so it is filtered by Quarkus. We should be careful around
encodings and byte limits in the future.
@fedinskiy fedinskiy added arch/aarch64 Issues for 64bit ARM architecture. triage/backport-3.15 labels Sep 24, 2024
@fedinskiy fedinskiy self-assigned this Sep 24, 2024
mjurc
mjurc approved these changes Sep 24, 2024
View reviewed changes
Copy link
Member

@mjurc mjurc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for quick turnaround :)

@mjurc mjurc merged commit 79e7de8 into quarkus-qe:main Sep 24, 2024
8 checks passed
@fedinskiy fedinskiy deleted the fix/arm branch September 24, 2024 15:38
@fedinskiy fedinskiy mentioned this pull request Sep 25, 2024
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjurc mjurc mjurc approved these changes

Assignees

@fedinskiy fedinskiy

Labels
arch/aarch64 Issues for 64bit ARM architecture.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fedinskiy @mjurc