-
Notifications
You must be signed in to change notification settings - Fork 759
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revisit dependencies with no direct usage #2524
Comments
|
I think we just need to use the new technique that doesn't immediately load these namespaces. |
devtools actually makes use of OTOH these are expedient
|
At the very least, update how we justify
Imports
that have no obvious direct usage within devtools. Determine if some of these@importFrom
s should be updated:devtools/R/devtools-package.R
Lines 13 to 16 in 9568e51
to instead use the technique described here:
https://r-pkgs.org/dependencies-in-practice.html#how-to-not-use-a-package-in-imports
This came up after a recent incident that reminded us that merely loading devtools causes shiny to be loaded (via miniUI), during the "package version as character" episode.
The text was updated successfully, but these errors were encountered: