fix: hrmp

[evilrobot-01]

Ensures hrmp channels work seamlessly via pop-cli.

Requires v1.3.3+ of the Paseo chain spec generator.

Test using:
cargo run -- up parachain -f ./tests/networks/pop.toml --verbose

[codecov]

Codecov Report

Attention: Patch coverage is 73.74302% with 47 lines in your changes missing coverage. Please review.

Project coverage is 75.11%. Comparing base (22a74b3) to head (863ab92).
Report is 3 commits behind head on main.

Files with missing lines	Patch %	Lines
crates/pop-cli/src/commands/up/parachain.rs	0.00%	28 Missing ⚠️
crates/pop-parachains/src/relay.rs	83.51%	15 Missing ⚠️
crates/pop-parachains/src/up/mod.rs	92.85%	0 Missing and 4 partials ⚠️

@@            Coverage Diff             @@
##             main     #278      +/-   ##
==========================================
+ Coverage   75.10%   75.11%   +0.01%     
==========================================
  Files          61       62       +1     
  Lines       13701    13869     +168     
  Branches    13701    13869     +168     
==========================================
+ Hits        10290    10418     +128     
- Misses       2056     2094      +38     
- Partials     1355     1357       +2     

Files with missing lines	Coverage Δ
crates/pop-cli/src/commands/call/chain.rs	74.64% <100.00%> (+0.11%)	⬆️
crates/pop-parachains/src/call/mod.rs	58.33% <100.00%> (+0.59%)	⬆️
crates/pop-parachains/src/utils/helpers.rs	79.77% <ø> (ø)
crates/pop-parachains/src/up/mod.rs	87.59% <92.85%> (+0.16%)	⬆️
crates/pop-parachains/src/relay.rs	83.51% <83.51%> (ø)
crates/pop-cli/src/commands/up/parachain.rs	7.00% <0.00%> (-0.61%)	⬇️

... and 1 file with indirect coverage changes

[evilrobot-01]

Rebased.

[Daanvdplas]

I noticed that when I build the chain-spec-generator and used it to spin up a local network the parachains were not producing blocks. Used the release binary and it worked. Not 100% sure I did something wrong or it is the chain spec generator. Just put it here so that we are aware.

[AlexD10S]

Looks good to me from a high-level perspective. Makes sense to replace https://github.com/r0gue-io/paseo-runtimes with https://github.com/r0gue-io/paseo-network-runtimes and begin maintaining it.

[evilrobot-01]

Makes sense to replace https://github.com/r0gue-io/paseo-runtimes with https://github.com/r0gue-io/paseo-network-runtimes and begin maintaining it.

Need to coordinate with Ale in terms of whether this could be upstreamed to Paseo repo, even if with some feature flag.

[al3mart]

Makes sense to replace https://github.com/r0gue-io/paseo-runtimes with https://github.com/r0gue-io/paseo-network-runtimes and begin maintaining it.

Need to coordinate with Ale in terms of whether this could be upstreamed to Paseo repo, even if with some feature flag.

I was reviewing the changes we made. I can confirm that now everything on Paseo' side is using sr25519. As for the hrmp at genesis that can and should be pushed upstream! There's no point on us keeping a fork if there's not that many changes.

I can take care of doing so 🤝

[evilrobot-01]

As for the hrmp at genesis that can and should be pushed upstream! There's no point on us keeping a fork if there's not that many changes.

I can take care of doing so 🤝

Should just be whatever is applicable at paseo-network/runtimes@main...r0gue-io:paseo-network-runtimes:pop. It would be great to get this into the next pop release, but that would require a Paseo release with the updated CSG.

[al3mart]

@evilrobot-01 v1.3.3 and v1.3.4 should present no blockers now.

[evilrobot-01]

Rebased

[AlexD10S]

Looks great to me, and I see you’ve addressed all of Peter’s comments.
Thank you for the hard work you’ve put into this!

[evilrobot-01]

Looks great to me, and I see you’ve addressed all of Peter’s comments.

Assume they will need resolving before merging. Figure its best to have whomever is merging to resolve to ensure they are happy, rather than me resolving and things get hidden.