Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hrmp #278

Merged
merged 25 commits into from
Dec 19, 2024

refactor: reuse spinner

863ab92
Select commit
Loading
Failed to load commit list.
Merged

fix: hrmp #278

refactor: reuse spinner
863ab92
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 19, 2024 in 1s

75.11% (+0.01%) compared to 22a74b3

View this Pull Request on Codecov

75.11% (+0.01%) compared to 22a74b3

Details

Codecov Report

Attention: Patch coverage is 73.74302% with 47 lines in your changes missing coverage. Please review.

Project coverage is 75.11%. Comparing base (22a74b3) to head (863ab92).

Files with missing lines Patch % Lines
crates/pop-cli/src/commands/up/parachain.rs 0.00% 28 Missing ⚠️
crates/pop-parachains/src/relay.rs 83.51% 15 Missing ⚠️
crates/pop-parachains/src/up/mod.rs 92.85% 0 Missing and 4 partials ⚠️
@@            Coverage Diff             @@
##             main     #278      +/-   ##
==========================================
+ Coverage   75.10%   75.11%   +0.01%     
==========================================
  Files          61       62       +1     
  Lines       13701    13869     +168     
  Branches    13701    13869     +168     
==========================================
+ Hits        10290    10418     +128     
- Misses       2056     2094      +38     
- Partials     1355     1357       +2     
Files with missing lines Coverage Δ
crates/pop-cli/src/commands/call/chain.rs 74.64% <100.00%> (+0.11%) ⬆️
crates/pop-parachains/src/call/mod.rs 58.33% <100.00%> (+0.59%) ⬆️
crates/pop-parachains/src/utils/helpers.rs 79.77% <ø> (ø)
crates/pop-parachains/src/up/mod.rs 87.59% <92.85%> (+0.16%) ⬆️
crates/pop-parachains/src/relay.rs 83.51% <83.51%> (ø)
crates/pop-cli/src/commands/up/parachain.rs 7.00% <0.00%> (-0.61%) ⬇️

... and 1 file with indirect coverage changes