feat: wallet integration #371
clippy
100 warnings
Details
Results
Message level | Amount |
---|---|
Internal compiler error | 0 |
Error | 0 |
Warning | 100 |
Note | 0 |
Help | 0 |
Versions
- rustc 1.83.0 (90b35a623 2024-11-26)
- cargo 1.83.0 (5ffbef321 2024-10-29)
- clippy 0.1.83 (90b35a6 2024-11-26)
Annotations
Check warning on line 13 in crates/pop-cli/src/commands/new/mod.rs
github-actions / clippy
missing documentation for a macro
warning: missing documentation for a macro
--> crates/pop-cli/src/commands/new/mod.rs:13:1
|
13 | macro_rules! enum_variants {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^
Check warning on line 133 in crates/pop-cli/src/main.rs
github-actions / clippy
missing documentation for the crate
warning: missing documentation for the crate
--> crates/pop-cli/src/main.rs:3:1
|
3 | / #[cfg(not(any(feature = "contract", feature = "parachain")))]
4 | | compile_error!("feature \"contract\" or feature \"parachain\" must be enabled");
5 | |
6 | | use anyhow::{anyhow, Result};
... |
132 | | }
133 | | }
| |_^
|
= note: requested on the command line with `-W missing-docs`
Check warning on line 258 in crates/pop-cli/src/commands/up/parachain.rs
github-actions / clippy
using `map` over `inspect`
warning: using `map` over `inspect`
--> crates/pop-cli/src/commands/up/parachain.rs:258:5
|
258 | .map(|b| {
| ^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_inspect
= note: `#[warn(clippy::manual_inspect)]` on by default
help: try
|
258 ~ .inspect(|b| {
259 | if latest && b.stale() {
260 | b.use_latest()
261 ~ }
|
Check warning on line 43 in crates/pop-cli/src/commands/clean.rs
github-actions / clippy
the following explicit lifetimes could be elided: 'a
warning: the following explicit lifetimes could be elided: 'a
--> crates/pop-cli/src/commands/clean.rs:43:6
|
43 | impl<'a, CLI: Cli> CleanCacheCommand<'a, CLI> {
| ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
= note: `#[warn(clippy::needless_lifetimes)]` on by default
help: elide the lifetimes
|
43 - impl<'a, CLI: Cli> CleanCacheCommand<'a, CLI> {
43 + impl<CLI: Cli> CleanCacheCommand<'_, CLI> {
|
Check warning on line 277 in crates/pop-cli/src/commands/call/chain.rs
github-actions / clippy
this expression creates a reference which is immediately dereferenced by the compiler
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> crates/pop-cli/src/commands/call/chain.rs:277:41
|
277 | submit_extrinsic_with_wallet(client, &url, call_data_bytes, cli)
| ^^^^ help: change this to: `url`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `#[warn(clippy::needless_borrow)]` on by default
Check warning on line 249 in crates/pop-parachains/src/templates.rs
github-actions / clippy
missing documentation for a method
warning: missing documentation for a method
--> crates/pop-parachains/src/templates.rs:249:2
|
249 | pub fn license(&self) -> Option<&str> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Check warning on line 245 in crates/pop-parachains/src/templates.rs
github-actions / clippy
missing documentation for a method
warning: missing documentation for a method
--> crates/pop-parachains/src/templates.rs:245:2
|
245 | pub fn is_audited(&self) -> bool {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Check warning on line 239 in crates/pop-parachains/src/templates.rs
github-actions / clippy
missing documentation for a method
warning: missing documentation for a method
--> crates/pop-parachains/src/templates.rs:239:2
|
239 | pub fn is_supported_version(&self, version: &str) -> bool {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Check warning on line 235 in crates/pop-parachains/src/templates.rs
github-actions / clippy
missing documentation for a method
warning: missing documentation for a method
--> crates/pop-parachains/src/templates.rs:235:2
|
235 | pub fn supported_versions(&self) -> Option<Vec<&str>> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Check warning on line 196 in crates/pop-parachains/src/templates.rs
github-actions / clippy
missing documentation for a variant
warning: missing documentation for a variant
--> crates/pop-parachains/src/templates.rs:196:2
|
196 | DeprecatedOpenZeppelinGeneric,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Check warning on line 153 in crates/pop-parachains/src/templates.rs
github-actions / clippy
missing documentation for a variant
warning: missing documentation for a variant
--> crates/pop-parachains/src/templates.rs:153:2
|
153 | OpenZeppelinEVM,
| ^^^^^^^^^^^^^^^
Check warning on line 138 in crates/pop-parachains/src/templates.rs
github-actions / clippy
missing documentation for a variant
warning: missing documentation for a variant
--> crates/pop-parachains/src/templates.rs:138:2
|
138 | OpenZeppelinGeneric,
| ^^^^^^^^^^^^^^^^^^^
Check warning on line 51 in crates/pop-parachains/src/templates.rs
github-actions / clippy
missing documentation for a struct field
warning: missing documentation for a struct field
--> crates/pop-parachains/src/templates.rs:51:2
|
51 | pub initial_endowment: String,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Check warning on line 50 in crates/pop-parachains/src/templates.rs
github-actions / clippy
missing documentation for a struct field
warning: missing documentation for a struct field
--> crates/pop-parachains/src/templates.rs:50:2
|
50 | pub decimals: u8,
| ^^^^^^^^^^^^^^^^
Check warning on line 49 in crates/pop-parachains/src/templates.rs
github-actions / clippy
missing documentation for a struct field
warning: missing documentation for a struct field
--> crates/pop-parachains/src/templates.rs:49:2
|
49 | pub symbol: String,
| ^^^^^^^^^^^^^^^^^^
Check warning on line 33 in crates/pop-parachains/src/templates.rs
github-actions / clippy
missing documentation for a variant
warning: missing documentation for a variant
--> crates/pop-parachains/src/templates.rs:33:2
|
33 | Parity,
| ^^^^^^
Check warning on line 26 in crates/pop-parachains/src/templates.rs
github-actions / clippy
missing documentation for a variant
warning: missing documentation for a variant
--> crates/pop-parachains/src/templates.rs:26:2
|
26 | OpenZeppelin,
| ^^^^^^^^^^^^
Check warning on line 19 in crates/pop-parachains/src/templates.rs
github-actions / clippy
missing documentation for a variant
warning: missing documentation for a variant
--> crates/pop-parachains/src/templates.rs:19:2
|
19 | Pop,
| ^^^
Check warning on line 86 in crates/pop-parachains/src/new_pallet/new_pallet_options.rs
github-actions / clippy
missing documentation for a variant
warning: missing documentation for a variant
--> crates/pop-parachains/src/new_pallet/new_pallet_options.rs:86:2
|
86 | CustomOrigin,
| ^^^^^^^^^^^^
Check warning on line 84 in crates/pop-parachains/src/new_pallet/new_pallet_options.rs
github-actions / clippy
missing documentation for a variant
warning: missing documentation for a variant
--> crates/pop-parachains/src/new_pallet/new_pallet_options.rs:84:2
|
84 | GenesisConfig,
| ^^^^^^^^^^^^^
Check warning on line 82 in crates/pop-parachains/src/new_pallet/new_pallet_options.rs
github-actions / clippy
missing documentation for a variant
warning: missing documentation for a variant
--> crates/pop-parachains/src/new_pallet/new_pallet_options.rs:82:2
|
82 | DefaultConfig,
| ^^^^^^^^^^^^^
Check warning on line 70 in crates/pop-parachains/src/errors.rs
github-actions / clippy
missing documentation for a variant
warning: missing documentation for a variant
--> crates/pop-parachains/src/errors.rs:70:2
|
70 | WorkspaceLocate,
| ^^^^^^^^^^^^^^^
Check warning on line 68 in crates/pop-parachains/src/errors.rs
github-actions / clippy
missing documentation for a variant
warning: missing documentation for a variant
--> crates/pop-parachains/src/errors.rs:68:2
|
68 | UnsupportedCommand(String),
| ^^^^^^^^^^^^^^^^^^
Check warning on line 66 in crates/pop-parachains/src/errors.rs
github-actions / clippy
missing documentation for a variant
warning: missing documentation for a variant
--> crates/pop-parachains/src/errors.rs:66:2
|
66 | TomlError(#[from] toml_edit::de::Error),
| ^^^^^^^^^
Check warning on line 64 in crates/pop-parachains/src/errors.rs
github-actions / clippy
missing documentation for a variant
warning: missing documentation for a variant
--> crates/pop-parachains/src/errors.rs:64:2
|
64 | SourcingError(#[from] pop_common::sourcing::Error),
| ^^^^^^^^^^^^^