-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: init git repo #65
Conversation
@AlexD10S can you review? |
Hello @CinematicCow! Amazing that you are contributing to our project.
That is because it is initialised at line 34 and 68. This is repetitive code and we should use your helper function. If you could remove the ones mentioned above and expand your test by including the situation of no git config and other test cases it would be amazing! |
Thanks for contributing into the project. As Daan said it looks like is initialize in another function in the Regarding to @weezy20 question, if no name or email the following line will throw an error: let signature = repo.signature()?; We want to display an error message to the user in that case? The rest of the code looks good to me, my only question is why we need the let commit_id = repo.commit(Some("HEAD"), &signature, &signature, message, &tree, &[])?; |
@AlexD10S The commit is required so that the parachain that's created by pop new is ready for manipulation by pop add |
Any ideas on how to handle the test on CI? |
Thank you for your contributions @CinematicCow. This is much needed to make |
This PR solves for #61. It initializes a new git repo with
initialized parachain
as the commit message. It takes the default global user config from git and uses it as the signature.Currently the test passes even if there is no
.git
dir in the new parachain. I need help with that.