3.13: correctly format disabled plugins in 'rabbitmq-plugins list' (backport #11197) #11198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
Since commit c0187ec the value of `running_version` is converted to_string (`nil` would become the empty string). But the formatter expected `running_version` to be `nil` if the plugin is not running. This did not match and not running/not enabled plugins were marked incorrectly as "pending upgrade to...". For example: ``` $ rabbitmq-plugins list trust -q [ ] rabbitmq_trust_store (pending upgrade to 3.13.0+51.g9145b53) $ rabbitmq-plugins list trust --formatter erlang -q #{status => running,format => normal, plugins => [#{enabled => not_enabled,name => rabbitmq_trust_store,running => false, version => <<"3.13.0+51.g9145b53">>,running_version => <<>>}]} ``` (cherry picked from commit 69eb2b9)
(cherry picked from commit 4a3806b)
(cherry picked from commit a21a609)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is #11190 by @gomoripeti that passes the formatter tests. I've also tweaked them a bit to make the input more diverse.
References #10865 #10870.
This is an automatic backport of pull request #11197 done by Mergify.