Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

3.13: correctly format disabled plugins in 'rabbitmq-plugins list' (backport #11197) #11198

Merged
merged 3 commits into from
May 9, 2024
Merged

3.13: correctly format disabled plugins in 'rabbitmq-plugins list' (backport #11197) #11198

merged 3 commits into from
May 9, 2024

Commits on May 9, 2024

  1. Don't show disabled plugins as pending upgrade 

    Since commit c0187ec the value of `running_version` is converted
to_string (`nil` would become the empty string). But the formatter
expected `running_version` to be `nil` if the plugin is not
running. This did not match and not running/not enabled plugins were
marked incorrectly as "pending upgrade to...".

For example:
```
$ rabbitmq-plugins list trust -q
[  ] rabbitmq_trust_store               (pending upgrade to 3.13.0+51.g9145b53)

$ rabbitmq-plugins list trust --formatter erlang -q
 #{status => running,format => normal,
  plugins =>
      [#{enabled => not_enabled,name => rabbitmq_trust_store,running => false,
         version => <<"3.13.0+51.g9145b53">>,running_version => <<>>}]}
```

(cherry picked from commit 69eb2b9)
    @gomoripeti @mergify
    gomoripeti authored and mergify[bot] committed May 9, 2024
    Configuration menu
    Copy the full SHA
    f4777f7 View commit details
    Browse the repository at this point in the history

  2. Makes PluginsFormatterTest pass 

    (cherry picked from commit 4a3806b)
    @michaelklishin @mergify
    michaelklishin authored and mergify[bot] committed May 9, 2024
    Configuration menu
    Copy the full SHA
    fd3e013 View commit details
    Browse the repository at this point in the history

  3. CLI: placate Dialyzer 

    (cherry picked from commit a21a609)
    @michaelklishin @mergify
    michaelklishin authored and mergify[bot] committed May 9, 2024
    Configuration menu
    Copy the full SHA
    11a10c1 View commit details
    Browse the repository at this point in the history