Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated bookValue to be TangibleBookValue #1783

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

ChNgineer
Copy link

Resolves #936 by retroactively changing bookValue from book value per share to TangibleBookValue from get_balance_sheet() and changed original bookValue to bookValuePerShare

retroactively change bookValue from bookValuePerShare to TangibleBookValue from get_balance_sheet() and changed original bookValue to bookValuePerShare
@@ -1751,6 +1751,9 @@ def get_mutualfund_holders(self, proxy=None, as_dict=False):
def get_info(self, proxy=None) -> dict:
self._quote.proxy = proxy or self.proxy
data = self._quote.info
data['bookValuePerShare'] = data['bookValue']
bal_sheet = self.get_balance_sheet()
Copy link
Collaborator

@ValueRaider ValueRaider Dec 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like this, introduces another GET request. Most people fetching info don't want book value - let those that do directly request balance sheet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants