Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updated bookValue to be TangibleBookValue #1783

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

updated bookValue to be TangibleBookValue #1783

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions yfinance/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1751,6 +1751,9 @@ def get_mutualfund_holders(self, proxy=None, as_dict=False):
def get_info(self, proxy=None) -> dict:
self._quote.proxy = proxy or self.proxy
data = self._quote.info
data['bookValuePerShare'] = data['bookValue']
bal_sheet = self.get_balance_sheet()
Copy link
Collaborator

@ValueRaider ValueRaider Dec 13, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like this, introduces another GET request. Most people fetching info don't want book value - let those that do directly request balance sheet.

data['bookValue'] = bal_sheet.loc['TangibleBookValue'][0]
return data

def get_fast_info(self, proxy=None):
Expand Down