Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v2.8] Fix flaky nodescaling test cases #141

Merged
merged 1 commit into from
Apr 8, 2024
Merged

[v2.8] Fix flaky nodescaling test cases #141

merged 1 commit into from
Apr 8, 2024

Conversation

markusewalker
Copy link
Contributor

2.8 backport of #134.

susesgartner
susesgartner approved these changes Apr 3, 2024
View reviewed changes
Copy link
Contributor

@susesgartner susesgartner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks for updating the polling in addition to your other logic changes

@markusewalker markusewalker mentioned this pull request Apr 3, 2024
Closed
@markusewalker markusewalker added area/release-testing Related to Release Testing automation-fix To indicate this is related to fixing code related to automation labels Apr 3, 2024
caliskanugur
caliskanugur approved these changes Apr 4, 2024
View reviewed changes
Copy link
Member

@caliskanugur caliskanugur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

igomez06
igomez06 approved these changes Apr 5, 2024
View reviewed changes
Copy link

@igomez06 igomez06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@igomez06 igomez06 merged commit d0c3b8d into rancher:release/v2.8 Apr 8, 2024
1 check passed
@markusewalker markusewalker deleted the markusv28/fix-release-issues branch April 8, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@susesgartner susesgartner susesgartner approved these changes

@Josh-Diamond Josh-Diamond Josh-Diamond approved these changes

@caliskanugur caliskanugur caliskanugur approved these changes

@slickwarren slickwarren slickwarren approved these changes

@igomez06 igomez06 igomez06 approved these changes

Assignees
No one assigned
Labels
area/release-testing Related to Release Testing automation-fix To indicate this is related to fixing code related to automation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@markusewalker @igomez06 @slickwarren @caliskanugur @Josh-Diamond @susesgartner