Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generic Permutations #279

Merged
merged 1 commit into from
Oct 25, 2024
Merged

Generic Permutations #279

merged 1 commit into from
Oct 25, 2024

Conversation

susesgartner
Copy link
Contributor

Purpose:

  1. To enable permuting of all fields in the cattle config so we can move forward with OS testing automation
  2. To lay some of the groundwork for replacing/deprecating provisioning/permutation

@susesgartner susesgartner self-assigned this Aug 28, 2024
slickwarren
slickwarren reviewed Aug 28, 2024
View reviewed changes
Copy link
Contributor

@slickwarren slickwarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some overarching questions:

  • can you provide some example runs i.e. in jenkins of this working?
  • can you also provide instructions on how to use this version of permutations

extensions/configoperations/configoperations.go Outdated Show resolved Hide resolved
extensions/configoperations/permutations/permutations.go Outdated Show resolved Hide resolved
@susesgartner susesgartner force-pushed the experimental branch 4 times, most recently from 53ae432 to d82a097 Compare August 31, 2024 03:56
@susesgartner susesgartner force-pushed the experimental branch 4 times, most recently from 8b4a7b1 to 13c9127 Compare September 9, 2024 21:45
slickwarren
slickwarren reviewed Sep 24, 2024
View reviewed changes
Copy link
Contributor

@slickwarren slickwarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some comments

extensions/configoperations/configoperations.go Outdated Show resolved Hide resolved
extensions/configoperations/configoperations.go Outdated Show resolved Hide resolved
extensions/configoperations/permutations/example_test.go Outdated Show resolved Hide resolved
extensions/configoperations/configoperations.go Outdated Show resolved Hide resolved
extensions/configoperations/configoperations.go Outdated Show resolved Hide resolved
extensions/configoperations/configoperations.go Outdated Show resolved Hide resolved
pkg/config/config.go Show resolved Hide resolved
extensions/configoperations/permutations/permutations.go Outdated Show resolved Hide resolved
@susesgartner susesgartner force-pushed the experimental branch 2 times, most recently from b9010a4 to fcc5c64 Compare September 30, 2024 14:41
markusewalker
markusewalker reviewed Oct 2, 2024
View reviewed changes
Copy link
Contributor

@markusewalker markusewalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, LGTM, left one comment. Will approve once resolved.

extensions/configoperations/permutations/example_test.go Outdated Show resolved Hide resolved
slickwarren
slickwarren previously approved these changes Oct 3, 2024
View reviewed changes
markusewalker
markusewalker previously approved these changes Oct 4, 2024
View reviewed changes
@caliskanugur caliskanugur added the automation-enhancement To indicate this is related to enhancements in code related to automation label Oct 8, 2024
caliskanugur
caliskanugur reviewed Oct 8, 2024
View reviewed changes
Copy link
Member

@caliskanugur caliskanugur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks solid, left some questions

pkg/config/config.go Show resolved Hide resolved
extensions/configoperations/configoperations.go Outdated Show resolved Hide resolved
@susesgartner susesgartner force-pushed the experimental branch 2 times, most recently from 790de76 to 468e0bf Compare October 18, 2024 14:30
@susesgartner susesgartner force-pushed the experimental branch 3 times, most recently from 557c6ba to fdfda64 Compare October 18, 2024 14:38
caliskanugur
caliskanugur approved these changes Oct 18, 2024
View reviewed changes
Copy link
Member

@caliskanugur caliskanugur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks solid to me, do we need backports for this?

markusewalker
markusewalker approved these changes Oct 23, 2024
View reviewed changes
Copy link
Contributor

@markusewalker markusewalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@susesgartner
initial commit
d2c3e00 
Add LoadConfigFromFile

Move config ops to a seperate file

fix typo

Update permutations.go

Update permutations.go

Update configoperations.go

Update permutations.go

Update configoperations.go

Create example_test.go

Update example_test.go

Update to address PR comments

Update example_test.go

update with correct locations

update directory location

update naming
This was referenced Oct 24, 2024
Merged
Merged
Merged
@caliskanugur caliskanugur merged commit 8ea8a1f into rancher:main Oct 25, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markusewalker markusewalker markusewalker approved these changes

@caliskanugur caliskanugur caliskanugur approved these changes

@slickwarren slickwarren slickwarren approved these changes

@Josh-Diamond Josh-Diamond Awaiting requested review from Josh-Diamond

@igomez06 igomez06 Awaiting requested review from igomez06

Assignees

@susesgartner susesgartner

Labels
automation-enhancement To indicate this is related to enhancements in code related to automation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@susesgartner @slickwarren @caliskanugur @markusewalker