Make more stuff adjustable #19
Conversation
Signed-off-by: C0D3 M4513R <[email protected]>
| @@ -14,13 +13,15 @@ | |||
| version, | |||
| src, | |||
| meta, | |||
| jdk ? pkgs.jdk, | |||
| gradle ? pkgs.gradle, | |||
There was a problem hiding this comment.
I guess that's reasonable in some cases. However, in most cases, overlays is probably the way to go.
There was a problem hiding this comment.
I don't know why I would use overlays here tbh.
That change was able to work for me with 0 issues.
(though I don't understand what overlays can and can't alter fully)
There was a problem hiding this comment.
sure, it works perfectly fine. Whenever possible, I prefer to have a single version of a JDK for - and by setting it explicitly in the overlay, it's used everywhere and not just for this package. But it's a matter of the use case I suppose 🤷.
| buildInputs ? [], | ||
| nativeBuildInputs ? [], | ||
| dependencyFilter ? depSpec: true, | ||
| repositories ? ["https://plugins.gradle.org/m2/" "https://repo1.maven.org/maven2/"], | ||
| verificationFile ? "gradle/verification-metadata.xml", | ||
| buildTask ? ":installDist", | ||
| installLocaltion ? "build/install/*/", | ||
| installLocation ? "build/install/*/", |
| python3, | ||
| git, | ||
| writeShellApplication, | ||
| }: { |
There was a problem hiding this comment.
@C0D3-M4513R FYI: I adapted this a bit on main. it's not a lambda anymore but you can customize all arguments using override.
This makes it less verbose when using it as buildInput in a devshell:
buildInputs = [jdk gradle updateVerificationMetadata]; # defaults
buildInputs = [jdk gradle (updateVerificationMetadata.override {updateAction = "party";})]; # override
…ication#19 is merged. This swaps back to the "original" project. Signed-off-by: C0D3 M4513R <[email protected]>
raphiz/buildGradleApplication#19 is merged. This swaps back to the "original" project. Signed-off-by: C0D3 M4513R <[email protected]>
raphiz/buildGradleApplication#19 is merged. This swaps back to the "original" project. Signed-off-by: C0D3 M4513R <[email protected]>
Also updates to nixos 24.05
Used in: Col-E/Recaf#805