Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3] Add blade reviews to templates #679

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

JimmyHoenderdaal
Copy link
Member

this should be merged after: rapidez/reviews#29

@@ -20,7 +20,7 @@
@includeWhen($product->type_id !== 'grouped', 'rapidez::product.partials.addtocart')
@if (App::providerIsLoaded('Rapidez\Reviews\ReviewsServiceProvider'))
@if ($product->reviews_score)
<stars :score="{{ $product->reviews_score }}" :count="{{ $product->reviews_count }}"></stars>
<x-rapidez-reviews::stars score="{{ $product->reviews_score }}" count="{{ $product->reviews_count }}" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<x-rapidez-reviews::stars score="{{ $product->reviews_score }}" count="{{ $product->reviews_count }}" />
<x-rapidez-reviews::stars :score="$product->reviews_score" :count="$product->reviews_count" />

This also works right?

@royduin
Copy link
Member

royduin commented Jan 15, 2025

  • There is a conflict
  • As this requires the latest version of rapidez/reviews we should make sure Composer knows. But.. it's not a requirement of the core; it's an optional package. I think defining a conflict is the best option here: https://getcomposer.org/doc/04-schema.md#conflict

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants