Changed review stars to blade #29
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Roene-JustBetter
previously approved these changes
Dec 20, 2024
Roene-JustBetter
approved these changes
Dec 20, 2024
indykoning
approved these changes
Dec 20, 2024
royduin
reviewed
Dec 20, 2024
Comment on lines
+10
to
+16
| <div | ||
| style="width: {{ $score }}%" | ||
| @if ($attributes->has('v-bind:score')) | ||
| v-bind:style="{ width: ({{ $attributes['v-bind:score'] }} || 0) + '%'}" | ||
| @endif | ||
| class="absolute inset-0 flex gap-0.5 overflow-hidden" | ||
| > |
There was a problem hiding this comment.
Could this be written cleaner with @attributes()? See: https://github.com/rapidez/blade-directives#attributes or is this the cleanest option?
jordythevulder
approved these changes
Dec 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the reviews to be without any vue templates
there is a new reviews stars component with documentation that can take php and vue data
The inputstars has also be refactored to be inside blade instead of with vue with some improved styling
also there is no need anymore for v-blur since nothing will jump on pageload
here is the core pr that utilizes these changes: rapidez/core#679