fix: gracefully handle null items #517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
itwbaer
changed the title
|
Hey @yoyo837, any chance I could get a review on this? This is my first contribution so let me know if I am missing anything or if you need more information. Thanks! |
|
Could you add some test case for it? |
Codecov Report
@@ Coverage Diff @@
## master #517 +/- ##
==========================================
+ Coverage 84.92% 87.00% +2.08%
==========================================
Files 6 6
Lines 252 254 +2
Branches 63 62 -1
==========================================
+ Hits 214 221 +7
+ Misses 38 33 -5
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
@yoyo837 Added! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per the DataTransferItem API, if
webkitGetAsEntry()is called on something that isn't a file or folder, null is returned. Sometimes when dragging and dropping a file, extra string meta data seems to be associated with the event (examples, dragging and dropping an image blob from a different browser tab, or dragging a message from the Outlook desktop app).This causes an exception to be thrown, because the
_traverseFileTreefunction assumes each item to be a validInternalDataTransferItem. The end result is any valid file in the items array will not get uploaded after this exception occurs. If we can instead gracefully handle this case, valid directories will still get crawled and valid files will still get uploaded.fix #514