Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] run_robot_test.sh - OC login and return value #943

Merged
merged 3 commits into from
Sep 27, 2023
Merged

[Fix] run_robot_test.sh - OC login and return value #943

merged 3 commits into from
Sep 27, 2023

Commits on Sep 26, 2023

  1. [Fix] run_robot_test.sh - OC login 

    This fixes OC login on my local Fedora 38 machine. Without this change,
the strings contain also `"`.

Also missing `-` in front of the switch isn't allowed.

Tested with Python based `yq` tool:

```
$ yq --version # https://github.com/kislyuk/yq
yq 3.2.3

$ yq --help
...
  -e               set the exit status code based on the output;
...
  -r               output raw strings, not JSON texts;
...
```
and also with GoLang based `yq` tool:
```
$ ./yq_linux_amd64 --version # https://github.com/mikefarah/yq
yq (https://github.com/mikefarah/yq/) version v4.35.2
$ ./yq_linux_amd64 --help
...
  -e, --exit-status                   set exit status if there are no matches or null or false is returned
...
  -r, --unwrapScalar                  unwrap scalar, print the value with no quotes, colors or comments. Defaults to true for yaml (default true)
...
```
    @jstourac
    jstourac committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    f8661b8 View commit details
    Browse the repository at this point in the history

  2. [Fix] run_robot_test.sh - fix return value 

    Return value in case of service account login could be wrong
    @jstourac
    jstourac committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    7b94102 View commit details
    Browse the repository at this point in the history

  3. [Fix] run_robot_test.sh - let's check return code of yq before oc login

    @jstourac
    jstourac committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    0cd5340 View commit details
    Browse the repository at this point in the history