Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added skip marker to test if azure KV config is not set. #10076

Merged
merged 1 commit into from
Jul 11, 2024
Merged

Added skip marker to test if azure KV config is not set. #10076

merged 1 commit into from
Jul 11, 2024

Conversation

paraggit
Copy link
Contributor

Added skip marker to test if azure KV config is not set.

@paraggit paraggit requested a review from a team as a code owner July 11, 2024 11:10
@pull-request-size pull-request-size bot added the size/S PR that changes 10-29 lines label Jul 11, 2024
@paraggit paraggit linked an issue Jul 11, 2024 that may be closed by this pull request
Test test_azure_kms_pv_encryption.py failed with 'TypeError'. #10035
Closed
@openshift-ci openshift-ci bot added the lgtm label Jul 11, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jul 11, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ebenahar, jilju, nehaberry, paraggit, sidhant-agrawal

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

ocs-ci
ocs-ci reviewed Jul 11, 2024
View reviewed changes
Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation

Cluster Name:
Cluster Configuration:
PR Test Suite: tier1
PR Test Path: tests/functional/pv/pv_encryption/test_azure_kms_pv_encryption.py
Additional Test Params:
OCP VERSION: 4.16
OCS VERSION: 4.16
tested against branch: master

Job PASSED.

@paraggit paraggit added the Verified Mark when PR was verified and log provided label Jul 11, 2024
@ebenahar ebenahar merged commit 78e027a into red-hat-storage:master Jul 11, 2024
6 of 7 checks passed
amr1ta pushed a commit to amr1ta/ocs-ci that referenced this pull request Jul 25, 2024
@paraggit
Added skip marker to test if azure KV config is not set. (red-hat-sto…
4726099 
…rage#10076)

Signed-off-by: Parag Kamble <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ocs-ci ocs-ci ocs-ci left review comments

@nehaberry nehaberry nehaberry approved these changes

@jilju jilju jilju approved these changes

@sidhant-agrawal sidhant-agrawal sidhant-agrawal approved these changes

@ebenahar ebenahar ebenahar approved these changes

Assignees

@ebenahar ebenahar

@sidhant-agrawal sidhant-agrawal

@jilju jilju

@nehaberry nehaberry

Labels
lgtm size/S PR that changes 10-29 lines Verified Mark when PR was verified and log provided
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test test_azure_kms_pv_encryption.py failed with 'TypeError'.
6 participants
@paraggit @ebenahar @sidhant-agrawal @jilju @nehaberry @ocs-ci