Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added skip marker to test if azure KV config is not set. #10076

Merged
merged 1 commit into from
Jul 11, 2024
Merged

Added skip marker to test if azure KV config is not set. #10076

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions ocs_ci/framework/pytest_customization/marks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@
MS_CONSUMER_TYPE,
HCI_PROVIDER,
BAREMETAL_PLATFORMS,
AZURE_KV_PROVIDER_NAME,
)
from ocs_ci.utility import version
from ocs_ci.utility.aws import update_config_from_s3
Expand Down Expand Up @@ -370,6 +371,11 @@
reason="KMS config not found in auth.yaml",
)

azure_kv_config_required = pytest.mark.skipif(
config.ENV_DATA["KMS_PROVIDER"].lower() != AZURE_KV_PROVIDER_NAME,
reason="Azure KV config required to run the test.",
)

external_mode_required = pytest.mark.skipif(
config.DEPLOYMENT.get("external_mode") is not True,
reason="Test will run on External Mode cluster only",
Expand Down
4 changes: 2 additions & 2 deletions tests/functional/pv/pv_encryption/test_azure_kms_pv_encryption.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
tier1,
green_squad,
azure_platform_required,
kms_config_required,
azure_kv_config_required,
polarion_id,
skipif_ocs_version,
skipif_managed_service,
Expand All @@ -24,7 +24,7 @@
@tier1
@green_squad
@azure_platform_required
@kms_config_required
@azure_kv_config_required
@skipif_ocs_version("<4.16")
@skipif_managed_service
@skipif_hci_provider_and_client
Expand Down
Loading