Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provider mode deployment with Hosted clusters #10120

Merged
merged 22 commits into from
Jul 24, 2024
Merged

Provider mode deployment with Hosted clusters #10120

merged 22 commits into from
Jul 24, 2024

Conversation

DanielOsypenko
Copy link
Contributor

@DanielOsypenko DanielOsypenko commented Jul 16, 2024 •
edited
Loading

Changes:

clusters: 
   hcp416-bm2-a:
     hosted_odf_version: "latest-4.16"

@DanielOsypenko DanielOsypenko requested a review from dahorak July 16, 2024 09:15
@DanielOsypenko DanielOsypenko self-assigned this Jul 16, 2024
@DanielOsypenko DanielOsypenko requested a review from a team as a code owner July 16, 2024 09:15
@DanielOsypenko DanielOsypenko requested a review from a team as a code owner July 16, 2024 13:06
@pull-request-size pull-request-size bot added size/M PR that changes 30-99 lines and removed size/XS labels Jul 16, 2024
@DanielOsypenko
Copy link
Contributor Author

It required some syntax changes around mathematic operators

flake8...................................................................Failed

  • hook id: flake8
  • exit code: 1

ocs_ci/ocs/scale_lib.py:340:39: E226 missing whitespace around arithmetic operator
ocs_ci/ocs/scale_lib.py:359:43: E226 missing whitespace around arithmetic operator
ocs_ci/ocs/scale_lib.py:365:55: E226 missing whitespace around arithmetic operator
ocs_ci/ocs/scale_lib.py:1305:59: E226 missing whitespace around arithmetic operator
ocs_ci/ocs/scale_lib.py:1878:64: E226 missing whitespace around arithmetic operator

@pull-request-size pull-request-size bot added size/L PR that changes 100-499 lines and removed size/M PR that changes 30-99 lines labels Jul 18, 2024
@DanielOsypenko DanielOsypenko changed the title get_compute_node_names - add hci_baremetal platform Provider mode deployment with Hosted clusters Jul 23, 2024
@DanielOsypenko
Copy link
Contributor Author

Tested https://ocs4-jenkins-csb-odf-qe.apps.ocp-c1.prod.psi.redhat.com/job/qe-deploy-ocs-cluster/40000/

ebondare
ebondare previously approved these changes Jul 23, 2024
View reviewed changes
@openshift-ci openshift-ci bot added the lgtm label Jul 23, 2024
dahorak
dahorak reviewed Jul 24, 2024
View reviewed changes
ocs_ci/deployment/metallb.py Outdated Show resolved Hide resolved
ocs_ci/deployment/metallb.py Outdated Show resolved Hide resolved
ocs_ci/deployment/metallb.py Outdated Show resolved Hide resolved
@DanielOsypenko
get_compute_node_names - add hci_baremetal platform
52bc349 
Signed-off-by: Daniel Osypenko <[email protected]>
@DanielOsypenko
remove lso validation on count of deployed PVCs
9869ff6 
Signed-off-by: Daniel Osypenko <[email protected]>
@DanielOsypenko
add hci_baremetal platform to scenarios where baremetal platform is used
6b81146 
Signed-off-by: Daniel Osypenko <[email protected]>
@DanielOsypenko
subscription kind changes dynamically, upon acm installation
73f0d34 
Signed-off-by: Daniel Osypenko <[email protected]>
@DanielOsypenko
correction 0.1
9b47d47 
Signed-off-by: Daniel Osypenko <[email protected]>
@DanielOsypenko
add optional param disable-default-sources
3e16c76 
Signed-off-by: Daniel Osypenko <[email protected]>
@DanielOsypenko
param fix
7701152 
Signed-off-by: Daniel Osypenko <[email protected]>
@DanielOsypenko
fix native-client verification method
cef2271 
Signed-off-by: Daniel Osypenko <[email protected]>
@DanielOsypenko
fix native-client verification method with additional assertions
62fcc64 
Signed-off-by: Daniel Osypenko <[email protected]>
@DanielOsypenko
encrease mch verification timeout
559733f 
Signed-off-by: Daniel Osypenko <[email protected]>
@DanielOsypenko
storage client fetch update
fcdaf9a 
Signed-off-by: Daniel Osypenko <[email protected]>
@DanielOsypenko
client verification retries added
4ef4ca9 
Signed-off-by: Daniel Osypenko <[email protected]>
@DanielOsypenko
prevent deploy CNV 2 times
f0cfba5 
Signed-off-by: Daniel Osypenko <[email protected]>
@DanielOsypenko
remove 4.15 dependency - network policy
775957e 
Signed-off-by: Daniel Osypenko <[email protected]>
@DanielOsypenko
icsp-bew-regestry-check
764ed61 
Signed-off-by: Daniel Osypenko <[email protected]>
@DanielOsypenko
icsp-bew-regestry fix 0.1
d7d49df 
Signed-off-by: Daniel Osypenko <[email protected]>
@DanielOsypenko
icsp-bew-regestry fix 0.2
1457524 
Signed-off-by: Daniel Osypenko <[email protected]>
@DanielOsypenko
icsp-bew-regestry fix 0.3
68ec195 
Signed-off-by: Daniel Osypenko <[email protected]>
@DanielOsypenko
icsp-bew-regestry fix 0.4
e6fb5b8 
Signed-off-by: Daniel Osypenko <[email protected]>
@DanielOsypenko
storage-client name attribute fix 0.5
3effd97 
Signed-off-by: Daniel Osypenko <[email protected]>
@DanielOsypenko
fix 0.6
97c8146 
Signed-off-by: Daniel Osypenko <[email protected]>
@DanielOsypenko DanielOsypenko force-pushed the fix_missed_platform_provider_mode branch from 1466204 to 97c8146 Compare July 24, 2024 11:51
@openshift-ci openshift-ci bot removed the lgtm label Jul 24, 2024
@DanielOsypenko
grammar-fixe
b36b868 
Signed-off-by: Daniel Osypenko <[email protected]>
@openshift-ci openshift-ci bot added the lgtm label Jul 24, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jul 24, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dahorak, DanielOsypenko, ebondare

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dahorak dahorak merged commit ea173fb into red-hat-storage:master Jul 24, 2024
5 of 6 checks passed
amr1ta pushed a commit to amr1ta/ocs-ci that referenced this pull request Jul 25, 2024
@DanielOsypenko
Provider mode deployment with Hosted clusters (red-hat-storage#10120)
18f1cd5 
Changes:
    fix leftover, to prevent issues such as https://ocs4-jenkins-csb-odf-qe.apps.ocp-c1.prod.psi.redhat.com/job/qe-deploy-ocs-cluster/39701/consoleFull (metallb installation and latest OCP fetch from release notes)
    changed made ODF and Hosted cluster installation done by completing jenkins stage 1. Deploy OCP cluster stage 2. Install OD, dependencies and Hosted Cluster
    clean ODF provider and native client validation. Fixed some issues failing on waiting just deployed resources
    ODF with "latest-4.16" now can be a version, set in

clusters:
   hcp416-bm2-a:
     hosted_odf_version: "latest-4.16"

"--olm-disable-default-sources" parametrization added
FIXES
prevent failures on converged deployment Provider and Hosted cluster red-hat-storage#10160

Signed-off-by: Daniel Osypenko <[email protected]>
petr-balogh added a commit to petr-balogh/ocs-ci that referenced this pull request Aug 2, 2024
@petr-balogh
Fix condition for verify_disks_lso_attached
879391d 
This PR: red-hat-storage#10120

Broke original condition:
if config.ENV_DATA.get("platform") != constants.BAREMETAL_PLATFORM:

and changed to:
if config.ENV_DATA.get("platform") in [
            constants.BAREMETAL_PLATFORM,
            constants.HCI_BAREMETAL,
        ]:

There should be `not in`. Which is fixed in this commit.

Signed-off-by: Petr Balogh <[email protected]>
petr-balogh added a commit to petr-balogh/ocs-ci that referenced this pull request Aug 2, 2024
@petr-balogh
Fix condition for verify_disks_lso_attached
c091bfb 
This PR: red-hat-storage#10120

Broke original condition:
if config.ENV_DATA.get("platform") != constants.BAREMETAL_PLATFORM:

and changed to:
if config.ENV_DATA.get("platform") in [
            constants.BAREMETAL_PLATFORM,
            constants.HCI_BAREMETAL,
        ]:

There should be `not in`. Which is fixed in this commit.

Signed-off-by: Petr Balogh <[email protected]>
@petr-balogh petr-balogh mentioned this pull request Aug 2, 2024
Closed
openshift-cherrypick-robot pushed a commit to openshift-cherrypick-robot/ocs-ci that referenced this pull request Aug 2, 2024
@petr-balogh
Fix condition for verify_disks_lso_attached
37336e3 
This PR: red-hat-storage#10120

Broke original condition:
if config.ENV_DATA.get("platform") != constants.BAREMETAL_PLATFORM:

and changed to:
if config.ENV_DATA.get("platform") in [
            constants.BAREMETAL_PLATFORM,
            constants.HCI_BAREMETAL,
        ]:

There should be `not in`. Which is fixed in this commit.

Signed-off-by: Petr Balogh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ebondare ebondare ebondare approved these changes

@dahorak dahorak dahorak approved these changes

@yitzhak12 yitzhak12 Awaiting requested review from yitzhak12

@jilju jilju Awaiting requested review from jilju

@nehaberry nehaberry Awaiting requested review from nehaberry

@amr1ta amr1ta Awaiting requested review from amr1ta

@fbalak fbalak Awaiting requested review from fbalak

Assignees

@dahorak dahorak

@ebondare ebondare

@DanielOsypenko DanielOsypenko

Labels
lgtm size/L PR that changes 100-499 lines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

prevent failures on converged deployment Provider and Hosted cluster
3 participants
@DanielOsypenko @dahorak @ebondare