Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Co-situated hub: Hub recovery after site-failure and failover/relocate of DR workloads #10126

Merged
merged 12 commits into from
Aug 14, 2024
Merged

Co-situated hub: Hub recovery after site-failure and failover/relocate of DR workloads #10126

merged 12 commits into from
Aug 14, 2024

Conversation

Akarsha-rai
Copy link
Contributor

No description provided.

@Akarsha-rai Akarsha-rai requested a review from a team as a code owner July 17, 2024 06:17
@pull-request-size pull-request-size bot added the size/L PR that changes 100-499 lines label Jul 17, 2024
@Akarsha-rai Akarsha-rai added team/e2e E2E team related issues/PRs Squad/Turquoise labels Jul 17, 2024
@Akarsha-rai Akarsha-rai mentioned this pull request Jul 17, 2024
Closed
parikshithb
parikshithb reviewed Jul 25, 2024
View reviewed changes
Copy link
Contributor

@parikshithb parikshithb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, one additions and a WA

...ional/disaster-recovery/metro-dr/test_app_failover_and_relocate_when_entire_one_zone_down.py Outdated Show resolved Hide resolved
...ional/disaster-recovery/metro-dr/test_app_failover_and_relocate_when_entire_one_zone_down.py Show resolved Hide resolved
...ional/disaster-recovery/metro-dr/test_app_failover_and_relocate_when_entire_one_zone_down.py Outdated Show resolved Hide resolved
@parikshithb parikshithb added the DR Metro and Regional DR related PRs label Jul 25, 2024
@Akarsha-rai Akarsha-rai requested a review from a team as a code owner July 26, 2024 11:57
@pull-request-size pull-request-size bot added size/XL and removed size/L PR that changes 100-499 lines labels Jul 26, 2024
@openshift-ci openshift-ci bot removed the lgtm label Aug 13, 2024
avd-sagare
avd-sagare previously approved these changes Aug 13, 2024
View reviewed changes
@openshift-ci openshift-ci bot added the lgtm label Aug 13, 2024
am-agrawa
am-agrawa previously approved these changes Aug 13, 2024
View reviewed changes
Shrivaibavi
Shrivaibavi previously approved these changes Aug 13, 2024
View reviewed changes
Copy link
Contributor

@Shrivaibavi Shrivaibavi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci openshift-ci bot removed the lgtm label Aug 14, 2024
@openshift-ci openshift-ci bot added the lgtm label Aug 14, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Aug 14, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Akarsha-rai, am-agrawa, avd-sagare, parikshithb, Shrivaibavi, sidhant-agrawal, vavuthu

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vavuthu vavuthu merged commit 644f6fd into red-hat-storage:master Aug 14, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@am-agrawa am-agrawa am-agrawa approved these changes

@vavuthu vavuthu vavuthu approved these changes

@Shrivaibavi Shrivaibavi Shrivaibavi approved these changes

@sidhant-agrawal sidhant-agrawal sidhant-agrawal approved these changes

@avd-sagare avd-sagare avd-sagare approved these changes

@parikshithb parikshithb parikshithb approved these changes

@hnallurv hnallurv hnallurv left review comments

Assignees

@parikshithb parikshithb

@avd-sagare avd-sagare

@sidhant-agrawal sidhant-agrawal

@Shrivaibavi Shrivaibavi

@vavuthu vavuthu

@hnallurv hnallurv

@am-agrawa am-agrawa

Labels
DR Metro and Regional DR related PRs lgtm size/XL Squad/Turquoise team/e2e E2E team related issues/PRs Verified Mark when PR was verified and log provided
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@Akarsha-rai @Shrivaibavi @parikshithb @avd-sagare @sidhant-agrawal @vavuthu @hnallurv @am-agrawa