Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid circular import when importing MCG #11106

Conversation

vavuthu
Copy link
Contributor

@vavuthu vavuthu commented Jan 6, 2025

Fixes: #11105

Signed-off-by: vavuthu [email protected]

@vavuthu vavuthu requested a review from a team as a code owner January 6, 2025 10:13
@vavuthu vavuthu added the team/ecosystem Ecosystem team related issues/PRs label Jan 6, 2025
@vavuthu
Copy link
Contributor Author

vavuthu commented Jan 6, 2025

verified locally

>>> from ocs_ci.ocs.resources.mcg import MCG
/home/vijay/VJ/projects/ocs-ci/venv1/lib64/python3.9/site-packages/paramiko/pkey.py:100: CryptographyDeprecationWarning: TripleDES has been moved to cryptography.hazmat.decrepit.ciphers.algorithms.TripleDES and will be removed from this module in 48.0.0.
  "cipher": algorithms.TripleDES,
/home/vijay/VJ/projects/ocs-ci/venv1/lib64/python3.9/site-packages/paramiko/transport.py:259: CryptographyDeprecationWarning: TripleDES has been moved to cryptography.hazmat.decrepit.ciphers.algorithms.TripleDES and will be removed from this module in 48.0.0.
  "class": algorithms.TripleDES,
>>> 

Copy link
Contributor

@shylesh shylesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link

openshift-ci bot commented Jan 7, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: petr-balogh, shylesh, vavuthu

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vavuthu vavuthu merged commit 27ec5a6 into red-hat-storage:master Jan 7, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm size/XS team/ecosystem Ecosystem team related issues/PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

circulat import issue when import MCG through interactive session
3 participants