Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid circular import when importing MCG #11106

Merged
merged 1 commit into from
Jan 7, 2025
Merged

avoid circular import when importing MCG #11106

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion ocs_ci/ocs/resources/pod.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@
import base64
from semantic_version import Version

from ocs_ci.ocs.bucket_utils import craft_s3_command
from ocs_ci.ocs.ocp import get_images, OCP, verify_images_upgraded
from ocs_ci.helpers import helpers
from ocs_ci.helpers.proxy import update_container_with_proxy_env
Expand Down Expand Up @@ -212,6 +211,9 @@ def exec_s3_cmd_on_pod(self, command, mcg_obj=None):
Returns:
Munch Obj: This object represents a returned yaml file
"""
# Importing here to avoid circular dependency
from ocs_ci.ocs.bucket_utils import craft_s3_command

return self.exec_cmd_on_pod(
craft_s3_command(command, mcg_obj),
out_yaml_format=False,
Expand Down
Loading