-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Centralize tooling configs in monorepo #4138
base: master
Are you sure you want to change the base?
Conversation
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
✅ Deploy Preview for redux-starter-kit-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 11be3ed:
|
Okay, what I think I'm seeing here is:
Can I get a summary of what lint rules changed? Also it looks like there's some commented out lint rules in the ESLint config |
Sure, so mostly what I did was, add 2 configs:
Along with |
could you add a |
Yeah sure! |
Hey @aryaemami59, is ESLint being run in CI anywhere? I just noticed we're not running it on React Redux and it's been bugged for a while in that repo. Our first job is currently |
@timdorr yeah I kinda knew we weren't running ESLint during CI, I think we're only running it for Reselect. Honestly my plan was to add it to CI after we take care of this one. If you want I can take care of it tomorrow. |
Can we separate out these changes into multiple PRs?
Also, why is |
fdec05d
to
6554bdf
Compare
I'm gonna split this into multiple PRs soon. |
edb6f9d
to
46238ff
Compare
70b29c1
to
222d09b
Compare
dce28aa
to
b1f235f
Compare
f192009
to
e8e30d6
Compare
6874f9d
to
63d803d
Compare
0ba9264
to
e2401a9
Compare
…d add config packages to publish job
This PR:
Part 1 of 3
This PR precedes #4606 and #4607.
This is the initial step in a three-part effort to centralize tooling configurations so they can be shared across multiple repos.
Subsequent PRs: