Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add graphile-migrate for managing migrations #45

Merged
merged 5 commits into from
Oct 10, 2023
Merged

feat: add graphile-migrate for managing migrations #45

merged 5 commits into from
Oct 10, 2023

Conversation

wgwz
Copy link
Contributor

@wgwz wgwz commented Sep 27, 2023 •
edited
Loading

Closes: #25

Base automatically changed from ryan/22-docker-and-test to main September 27, 2023 21:13
@wgwz wgwz changed the title (WIP) feat: add graphile-migrate for managing migrations feat: add graphile-migrate for managing migrations Sep 27, 2023
@wgwz wgwz changed the base branch from main to fix-poetry-dep-issue September 28, 2023 00:16
Base automatically changed from fix-poetry-dep-issue to main September 28, 2023 17:12
@wgwz wgwz force-pushed the kyle/23-pg-migrate branch 2 times, most recently from d2c61cc to 967fa7f Compare September 28, 2023 19:23
@wgwz wgwz marked this pull request as ready for review September 28, 2023 20:29
@wgwz
Copy link
Contributor Author

wgwz commented Sep 28, 2023

The failing tests to the best of knowledge is just intermittent dockerhub issues, various 503 errors from there etc.
Will have to re-run these soon.

@wgwz wgwz requested a review from a team September 28, 2023 20:30
@ryanchristo
Copy link
Member

Like GitHub, Docker Hub may have intermittent service from time to time. You can view the status here:

@ryanchristo
Copy link
Member

image

blushi
blushi reviewed Oct 3, 2023
View reviewed changes
Copy link
Member

@blushi blushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could successfully run the graphile-migrate reset script, just a few comments

.gitignore Show resolved Hide resolved
migrations/README.md Show resolved Hide resolved
blushi
blushi approved these changes Oct 4, 2023
View reviewed changes
Copy link
Member

@blushi blushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pre-approving

@blushi blushi mentioned this pull request Oct 4, 2023
Merged
@wgwz wgwz merged commit b350edd into main Oct 10, 2023
1 check passed
@wgwz wgwz deleted the kyle/23-pg-migrate branch October 10, 2023 19:47
@wgwz wgwz mentioned this pull request Oct 19, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blushi blushi blushi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use postgraphile-migrate for managing migrations
3 participants
@wgwz @ryanchristo @blushi