-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: rocksdb and non-state-breaking version bumps #677
Conversation
Codecov Report
@@ Coverage Diff @@
## master #677 +/- ##
==========================================
- Coverage 74.74% 66.86% -7.88%
==========================================
Files 118 105 -13
Lines 19542 14692 -4850
==========================================
- Hits 14606 9824 -4782
- Misses 3963 4106 +143
+ Partials 973 762 -211
Flags with carried forward coverage won't be shown. Click here to find out more. |
NB: I am not sure why this seems to have affected test coverage (and lots) It doesn't change any of the code in regen-ledger |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for contribution. Could you resolve conflicts?
go.mod
Outdated
) | ||
|
||
replace google.golang.org/grpc => google.golang.org/grpc v1.33.2 | ||
|
||
replace github.com/tecbot/gorocksdb => github.com/cosmos/gorocksdb v1.1.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this permanent? Or is there a plan to upstream the cosmos changes to tecbot, and use tecbot in the future?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we have custom changes in gorocksdb for store/v2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have v1.2.0
, so let's use v1.2.0
@faddat can you resolve the conflicts or would you prefer one of us to do so? |
let's update cosmos/gorocksdb to v1.2.0 |
gentle ping @faddat |
@faddat could you resolve the conflicts? Thanks. |
Head branch was pushed to by a user without write access
Description
In most cosmos chains, rocksdb doesn't work but it is the cheapest possible performance boost, and this matters for embedded devices.
For a sync from genesis, you'll find that this is also a dramatic performance boost.
For relaying, this will help avoid account sequence errors.
PS: We ("the community") need a way to quantify this stuff beyond "it's faster, trust me" but here's my best try:
tendermint/tm-db#211
I'll try more and it'll get better.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change