-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(replacements): framer-motion to motion #32844
base: main
Are you sure you want to change the base?
feat(replacements): framer-motion to motion #32844
Conversation
"matchDatasources": ["npm"], | ||
"matchPackageNames": ["framer-motion"], | ||
"replacementName": "motion", | ||
"replacementVersion": "11.11.12" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not ideal because it could result in a rollback of versions.
I think that while @mattgperry is releasing both packages in parallel, maybe Renovate shouldn't proactively replace framer-motion
with motion
. If/once framer-motion
is stopped then we no longer have a moving target for the replacement
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should support replace name only. so we can simply leave the replacement version undefined and retain the current version for such use cases
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK so requires a modification to the replacement logic to accept empty replacement version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think so. @zharinov do you know?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like so 🤷♂️
Blocked by #33033 |
Changes
Created a replacement rule for
framer-motion
with its continuation packagemotion
.Context
The package has been published as
motion
since version 11.11.12 following the merger between Framer Motion and Motion One.Proof:
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: