Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(replacements): framer-motion to motion #32844

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
+13 −0
Draft

feat(replacements): framer-motion to motion #32844

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions lib/data/replacements.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
"replacements:eslint-plugin-vitest-to-scoped",
"replacements:fakerjs-to-scoped",
"replacements:fastify-to-scoped",
"replacements:framer-motion-to-motion",
"replacements:hapi-to-scoped",
"replacements:jade-to-pug",
"replacements:joi-to-scoped",
Expand Down Expand Up @@ -670,6 +671,18 @@
}
]
},
"framer-motion-to-motion": {
"description": "`framer-motion` and Motion One have merged under the package name `motion`, though `framer-motion` is still being published. `motion` is now the recommended name.",
"packageRules": [
{
"matchCurrentVersion": ">=11.11.12",
"matchDatasources": ["npm"],
"matchPackageNames": ["framer-motion"],
"replacementName": "motion",
"replacementVersion": "11.11.12"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not ideal because it could result in a rollback of versions.

I think that while @mattgperry is releasing both packages in parallel, maybe Renovate shouldn't proactively replace framer-motion with motion. If/once framer-motion is stopped then we no longer have a moving target for the replacement

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should support replace name only. so we can simply leave the replacement version undefined and retain the current version for such use cases

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK so requires a modification to the replacement logic to accept empty replacement version?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think so. @zharinov do you know?

Copy link
Collaborator

@zharinov zharinov Dec 10, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like so 🤷‍♂️

}
]
},
"hapi-to-scoped": {
"description": "`hapi` became scoped.",
"packageRules": [
Expand Down