Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Member Ignoring Method smell in ConditionSerializer class #311

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Refactor Member Ignoring Method smell in ConditionSerializer class #311

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a44ecca
Refactor Member Ignoring Method smell in ConditionSerializer class
emaiannone Jan 18, 2020
fa30b32
Update ConditionSerializer.java
renyuneyun Feb 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions ...rc/main/java/ryey/easer/core/data/storage/backend/json/condition/ConditionSerializer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,10 +44,10 @@ public String serialize(ConditionStructure data) throws UnableToSerializeExcepti
}
}

private JSONObject serialize_condition(ConditionData condition) throws JSONException {
JSONObject json_situation = new JSONObject();
json_situation.put(C.SPEC, LocalSkillRegistry.getInstance().condition().findSkill(condition).id());
json_situation.put(C.DATA, condition.serialize(PluginDataFormat.JSON));
return json_situation;
}
private static JSONObject serialize_condition(ConditionData condition) throws JSONException {
JSONObject json_situation = new JSONObject();
json_situation.put(C.SPEC, LocalSkillRegistry.getInstance().condition().findSkill(condition).id());
json_situation.put(C.DATA, condition.serialize(PluginDataFormat.JSON));
return json_situation;
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indent is wrong

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your feedback. Yeah, I already know this issue, it's because the tool works through ASTs, and I leave the default reformatting of the library when i write back the changes into source files.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right... I misspelt the word.

}