-
-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Rails 8 support #421
base: master
Are you sure you want to change the base?
Add Rails 8 support #421
Conversation
Failures seem to be related to rails/rails#53904 |
I was about to suggest this test matri change to the previous PR
I think there's absolutely nothing wrong in requiring Ruby 3.2+ for this release. Applications, projecs, people who need to stick to older Ruby versions will most likely also need to stick to older Rails/ActiveRecord releases and can use older versions of this gem |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @teeparham. This looks good! The issue you linked seems to be for rails 7.2. Do you know if it's going to be merged into the next release of 8.0 too? I tried looking around release notes and commit history but didn't see anything.
@januszm agree. Rails 8 requires 3.2+ so we should match that. |
This PR is #419, plus two small commits: