Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Rails 8 support #421

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -39,12 +39,12 @@ jobs:
--health-timeout 5s
--health-retries 5
env:
BUNDLE_GEMFILE: ${{matrix.gemfile}}
AR_VERSION: 8.0.0.1
strategy:
fail-fast: false
matrix:
# https://ruby-lang.org/en/downloads/branches
ruby: ["3.3", "3.2", "3.1"]
ruby: ["3.4", "3.3", "3.2"]
# https://www.postgresql.org/support/versioning/
pg: [12-master, 13-master, 14-master, 15-master, 16-master]
steps:
Expand Down
3 changes: 2 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -8,5 +8,6 @@ Gemfile.lock
/travis/*.lock
/test/database_local.yml
.idea
debug.log
debug.log*
/test/db/*
/test/storage/
4 changes: 2 additions & 2 deletions activerecord-postgis-adapter.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,9 @@ Gem::Specification.new do |spec|
spec.platform = Gem::Platform::RUBY

# ruby-lang.org/en/downloads/branches
spec.required_ruby_version = ">= 3.1.0"
spec.required_ruby_version = ">= 3.2.0"

spec.add_dependency "activerecord", "~> 7.2.0"
spec.add_dependency "activerecord", "~> 8.0.0"
spec.add_dependency "rgeo-activerecord", "~> 8.0.0"

spec.add_development_dependency "rake", "~> 13.0"
Expand Down
3 changes: 0 additions & 3 deletions test/database.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,15 +7,13 @@ connections:
username: <%= ENV["PGUSER"] || "postgres" %>
password: <%= ENV["PGPASSWORD"] || "" %>
setup: default
schema_search_path: public
arunit2:
host: <%= ENV["PGHOST"] || "127.0.0.1" %>
port: <%= ENV["PGPORT"] || "5432" %>
database: <%= ENV["PGDATABASE"] || "postgis_adapter_test" %>
username: <%= ENV["PGUSER"] || "postgres" %>
password: <%= ENV["PGPASSWORD"] || "" %>
setup: default
schema_search_path: public
arunit_without_prepared_statements:
min_messages: warning
prepared_statements: false
Expand All @@ -25,4 +23,3 @@ connections:
username: <%= ENV["PGUSER"] || "postgres" %>
password: <%= ENV["PGPASSWORD"] || "" %>
setup: default
schema_search_path: public
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
exclude "test_#resolve_raises_if_the_adapter_is_using_the_pre_7.2_adapter_registration_API", TRIAGE_MSG
4 changes: 2 additions & 2 deletions test/excludes/CounterCacheTest.rb
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
exclude "test_decrement_counter", TRIAGE_MSG
exclude "test_reset_counters_with_touch:_true", TRIAGE_MSG
exclude "test_reset_the_right_counter_if_two_have_the_same_foreign_key", TRIAGE_MSG
exclude "test_inactive_conter_cache", TRIAGE_MSG
exclude "test_inactive_counter_cache", TRIAGE_MSG
exclude "test_update_counters_of_multiple_records", TRIAGE_MSG
exclude "test_counters_are_updated_both_in_memory_and_in_the_database_on_create", TRIAGE_MSG
exclude "test_update_counter_with_initial_null_value", TRIAGE_MSG
Expand All @@ -47,7 +47,7 @@
exclude "test_reset_counters_with_touch:_:written_on", TRIAGE_MSG
exclude "test_reset_counters_for_cpk_model", TRIAGE_MSG
exclude "test_reset_the_right_counter_if_two_have_the_same_class_name", TRIAGE_MSG
exclude "test_active_conter_cache", TRIAGE_MSG
exclude "test_active_counter_cache", TRIAGE_MSG
exclude "test_increment_counters_with_touch:_:written_on", TRIAGE_MSG
exclude "test_update_multiple_counters_with_touch:_:written_on", TRIAGE_MSG
exclude "test_counter_cache_column?", TRIAGE_MSG
Expand Down
3 changes: 3 additions & 0 deletions test/excludes/SchemaDumperTest.rb
Original file line number Diff line number Diff line change
@@ -1,2 +1,5 @@
exclude "test_schema_dump_with_timestamptz_datetime_format", TRIAGE_MSG
exclude "test_schema_dump_when_changing_datetime_type_for_an_existing_app", TRIAGE_MSG
if ActiveRecord::Base.lease_connection.pool.server_version(ActiveRecord::Base.lease_connection) < 15_00_00
exclude "test_schema_dumps_unique_constraints", TRIAGE_MSG
end
Loading