Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear data and fix the short link when the close button is clicked. #886

Merged

Conversation

CherifAmine
Copy link
Contributor

Description

Changes Made

Closes Issue(s)

Related Issue(s)

#860

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Optimization (provides speedup with no functional changes)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Automated testing implementation or update
  • Dependencies updated to a newer version
  • Documentation update
  • Experimental feature that requires further discussion

Screenshots and screen captures

@CherifAmine CherifAmine added component: labels Changes related to labeling or categorization of issues or pull requests. component: presets Changes related to predefined settings or configurations. component: rooms Changes related to virtual meeting rooms or spaces. labels Aug 27, 2023
@sonarcloud
Copy link

sonarcloud bot commented Aug 27, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

No Coverage information No Coverage information
0.6% 0.6% Duplication

@marwa-benhassine marwa-benhassine added the quality control: approved Changes Requested (for feedback from the QA testing team) label Aug 28, 2023
@GhaziTriki GhaziTriki added the technical review: approved Approved (for when the technical team approves the changes) label Aug 30, 2023
@GhaziTriki GhaziTriki merged commit 3db340a into riadvice:develop Aug 30, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: labels Changes related to labeling or categorization of issues or pull requests. component: presets Changes related to predefined settings or configurations. component: rooms Changes related to virtual meeting rooms or spaces. quality control: approved Changes Requested (for feedback from the QA testing team) technical review: approved Approved (for when the technical team approves the changes)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants