Cleanup and added features #8
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Falco20019
commented
Aug 26, 2024
Falco20019
commented
- Cleanup of some constant usings
- Unification of baseUrl usage
- Extraction of report generation for others to use
- Addition of DistroessedExceptional for checking the json file against a common logic (to be extracted into a separate JSON in the future)
|
This will take me a few days to get to. Just an ACK that I have seen and will look look at this. |
|
Closing and re-opening to get the PR to run the new CI. |
richlander
reviewed
Aug 30, 2024
| @@ -100,9 +104,15 @@ public record SdkComponent( | |||
| [property: Description("The version of Visual Studio that includes this component version.")] | |||
| string VSVersion, | |||
|
|
|||
| [property: Description("The version of Visual Studio on MacOS that includes this component version.")] | |||
There was a problem hiding this comment.
I'm not in favor of adding these. At this point, these properties are pure legacy. What is the motivation for keeping them?
There was a problem hiding this comment.
I did not intentionally add those. I only rebased what I already had onto your latest state and it seems they were re-added by that. I will remove them once I‘m back in office mid next week. Thanks for noticing!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.