Refactor the resource type Dashboard to Canvas
#5726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* refac: update resource kind and use canvas terminology * Update definitions * Update definitions for admin * Fix for ts files * Remove leftover logs
k-anshul
approved these changes
Sep 20, 2024
| @@ -31,6 +31,7 @@ export function isMetricsExplorerPage(page: Page): boolean { | |||
| } | |||
|
|
|||
| export function isCanvasDashboardPage(page: Page): boolean { | |||
| // TODO: Change the route to canvas | |||
There was a problem hiding this comment.
Does this require addressing before merge ?
There was a problem hiding this comment.
No, this can be addressed later in a separate PR. It's more to do with file structuring in the application code
begelundmuller
deleted the
begelundmuller/refactor-dashboard-to-canvas
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the
rill.runtime.v1.Dashboardresource type torill.runtime.v1.Canvas. In the YAML files, the new type property istype: canvas.This is a breaking change that requires changing YAML files from
type: dashboardtotype: canvas.PR for frontend changes - #5730
Closes #5710