refac: update resource kind and use canvas terminology #5730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djbarnwal
changed the title
ericpgreen2
approved these changes
Sep 19, 2024
| @@ -177,6 +177,8 @@ | |||
|
|
|||
| if ($autoSave) await updateComponentFile(); | |||
| } | |||
|
|
|||
| $: console.log("errors", errors); | |||
| @@ -43,6 +43,8 @@ | |||
|
|
|||
| $: workspace = workspaces.get(resourceKind ?? $inferredResourceKind); | |||
|
|
|||
| $: console.log(workspace); | |||
djbarnwal
merged commit f457ca7
into
begelundmuller/refactor-dashboard-to-canvas
4 checks passed
begelundmuller
added a commit
that referenced
this pull request
Sep 20, 2024
* Refactor the resource type `Dashboard` to `Canvas` * Rename files * refac: update resource kind and use canvas terminology (#5730) * refac: update resource kind and use canvas terminology * Update definitions * Update definitions for admin * Fix for ts files * Remove leftover logs --------- Co-authored-by: Dhiraj Barnwal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on top of #5726
Updates resource type from
dashboardtocanvasAlso consolidate some variable names from
dashboard,custom-dashboard&canvas-dashboardtocanvas