Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates to address issues 64, 65 (chapter 9) #66

Merged
merged 2 commits into from
Mar 1, 2024
Merged

Updates to address issues 64, 65 (chapter 9) #66

merged 2 commits into from
Mar 1, 2024

Conversation

rsahita
Copy link
Collaborator

@rsahita rsahita commented Feb 27, 2024

No description provided.

This was referenced Feb 27, 2024
Closed
Closed
@rsahita
Copy link
Collaborator Author

rsahita commented Feb 27, 2024 •
edited
Loading

cc @ozkoyuncu @atishp04

rsahita
rsahita commented Mar 1, 2024
View reviewed changes
specification/sbi_cove.adoc Outdated Show resolved Hide resolved
rsahita
rsahita commented Mar 1, 2024
View reviewed changes
specification/sbi_cove.adoc Outdated Show resolved Hide resolved
@atishp04
Copy link
Contributor

atishp04 commented Mar 1, 2024

Apart from the above nit: lgtm.

rsahita
rsahita commented Mar 1, 2024
View reviewed changes
specification/sbi_cove.adoc Outdated Show resolved Hide resolved
@rsahita rsahita removed the request for review from ved-rivos March 1, 2024 22:49
@rsahita rsahita merged commit 3cc84eb into riscv-non-isa:main Mar 1, 2024
2 checks passed
@rsahita rsahita deleted the topic/spec-chap9 branch March 1, 2024 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sameo sameo sameo left review comments

@atishp04 atishp04 atishp04 left review comments

@ozkoyuncu ozkoyuncu ozkoyuncu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rsahita @atishp04 @sameo @ozkoyuncu